dotnet / aspire

Tools, templates, and packages to accelerate building observable, production-ready apps
https://learn.microsoft.com/dotnet/aspire
MIT License
3.92k stars 479 forks source link

[WebToolsE2E][Aspire] The attribute value column in the resource table does not support sorting yet. #6008

Open v-sherryfan opened 1 month ago

v-sherryfan commented 1 month ago

REGRESSION INFO: This is a new feature added in Aspire 9.0 RC1

INSTALL STEPS

  1. Clean machine: Win11 x64 23h2 ENU
  2. Install SDK 8.0.402
  3. Install Aspire 9.0 RC1 [9.0.0-preview.4.24478.1]

REPRO STEPS

  1. Open CMD, run following command to create an Aspire Starter App project
    dotnet new aspire-starter -o AspireStarterApp
    cd AspireStarterApp/AspireStarterApp.AppHost
  2. Dotnet run the project in CMD, and open URL in the browser. dotnet run
  3. Go to Resources page, click a resource. The attribute value column in the resource table does not support sorting.

ACTUAL In the Resource table, the Value column does not support sorting. image

EXPECTED Should have the same appearance and functionality as the endpoint and environment variables tables. image

v-sherryfan commented 1 month ago

I see that issue https://github.com/dotnet/aspire/issues/5377 has been fixed in Aspire 9.0 RC1, but the attribute value column in the resource table still does not support sorting. So I opened this issue to confirm whether it is by design.

adamint commented 1 month ago

We explicit set sortable to false in ResourceDetails, but before closing as by design, tagging @JamesNK

JamesNK commented 1 month ago

I'm not sure why it is false. Is there a reason to not make it true and consistent?