search

dotnet / aspire

Tools, templates, and packages to accelerate building observable, production-ready apps
https://learn.microsoft.com/dotnet/aspire
MIT License
3.93k stars 480 forks source link

[release/9.0] Don't display telemetry actions when no telemetry #6571

Closed github-actions[bot] closed 2 weeks ago

github-actions[bot] commented 3 weeks ago

Backport of #6568 to release/9.0

/cc @JamesNK

Customer Impact

Aspire 9 added telemetry quick links to the resource action menu. If there is no telemetry for a resource then the links are disabled. If there is telemetry they are enabled.

The match between the Aspire resource and the telemetry resource is based on the name. If the names are different then disabled links are shown. This is undesirable because the Aspire resource does have telemetry, just with a slightly different name. The user could be confused.

The fix is to not show disabled telemetry links. If the names don't match then there is no down side, and if the names do match then the links are available.

Testing

Manual

telemetry-menu-items2

Risk

Low

Regression?

Kind of. Aspire 9 adds "incorrect" telemetry links in dashboard usage when Aspire and telemetry resource names don't match.

Microsoft Reviewers: Open in CodeFlow
joperezr commented 2 weeks ago

Re-opening this as we want to take it as part of a special build for ACA. This will not be part of the 9.0.0 release, and instead will be branded as 9.0.1-preview