search

dotnet / aspire

Tools, templates, and packages to accelerate building observable, production-ready apps
https://learn.microsoft.com/dotnet/aspire
MIT License
3.91k stars 476 forks source link

Configure OpenAI models in the app host #6577

Open sebastienros opened 3 weeks ago

sebastienros commented 3 weeks ago

Building over @SteveSandersonMS PR to demonstrate the end-to-end experience when ai models/deployments are configured at the host level only.

Microsoft Reviewers: Open in CodeFlow
SteveSandersonMS commented 2 weeks ago

Overall looks great. @eerhardt's point about the breaking change is probably the main thing to consider. Besides that it looks pretty close to being ready.

sebastienros commented 1 week ago

I updated the PR. @SteveSandersonMS is this something we could merge in your PR as it's impacting how configuration is passed to the clients. Other option is I wait for your PR to be done and then react to the changes.

SteveSandersonMS commented 1 week ago

@sebastienros I'm fine with it being merged into my PR, but my PR itself can't be completed until we get the next build of Microsoft.Extensions.AI, because the agreed API shape depends on API changes we've just merged into dotnet/extensions today.

sebastienros commented 1 week ago

@eerhardt does it make sense to split this PR in two: the deployment API changes creating the ENVs, and the MEAI part that is using it and would be part of Steve's.

Or just move everything to Steve's branch and ship everything at once.

eerhardt commented 4 days ago

@eerhardt does it make sense to split this PR in two: the deployment API changes creating the ENVs, and the MEAI part that is using it and would be part of Steve's.

Or just move everything to Steve's branch and ship everything at once.

Completely up to you and Steve. I don't see a reason why they would need to be separate, but if you think they should be, I wouldn't argue.