Open IEvangelist opened 3 days ago
There are 3 Azure ones that appear to be missed:
(Although, that EventHubs one appears misplaced. It should be on the RunAsEmulator
method.)
Can you make sure this works as expected? This is a 2-level reference:
I recently created a PR that was fixing all these. Didn't we merge release/9.0 back to main? Pretty sure I updated everything to use
Yes, that's it, check the release/9.0, it's fine there: https://github.com/dotnet/aspire/blob/release/9.0/src/Aspire.Hosting.Elasticsearch/ElasticsearchContainerImageTags.cs
release/9.0 is fine, but the PR didn't get merged back correctly apparently (conflicts got resolved using main) https://github.com/dotnet/aspire/pull/6433
There might be an issue with the .NET API docs. I'm investigating that and will report back.
Description
Many of the container-based hosting integrations include an
internal
tags class, that stores the various container registry, image and tags. Since these members areinternal
the .NET Aspire API docs doesn't expose them in the rendered API docs. Nor are they available to IntelliSense.For example, see
RedisBuilderExtensions.AddRedis
Method: Remarks.To fix this, when we rely on
<inheritdoc />
we must specify thepath
(XPath) to the desired value. Before my change:After my change:
This will also fix the .NET Aspire API docs too, the next time we release.
Checklist
<remarks />
and<code />
elements on your triple slash comments?Does the change require an update in our Aspire docs?
breaking-change
template):doc-idea
template):Microsoft Reviewers: Open in CodeFlow