dotnet / aspire

Tools, templates, and packages to accelerate building observable, production-ready apps
https://learn.microsoft.com/dotnet/aspire
MIT License
3.91k stars 475 forks source link

Fix container tags comments #6747

Open sebastienros opened 1 day ago

sebastienros commented 1 day ago

Description

Some changes that were done in release/9.0 were not merged back to main due to conflicts. This is fixing it. This should supersede https://github.com/dotnet/aspire/pull/6718 which was opting to point to the <summary/> tag instead, but this would be opposite to what we have in release/9.0.

Fixes # (issue)

Checklist

sebastienros commented 1 day ago

@eerhardt I couldn't understand some of your comments on the other PR, like https://github.com/dotnet/aspire/pull/6718#issuecomment-2483835343 and https://github.com/dotnet/aspire/pull/6718#issuecomment-2483827603. I don't any issue with these.

eerhardt commented 17 hours ago

@eerhardt I couldn't understand some of your comments on the other PR, like #6718 (comment) and #6718 (comment). I don't any issue with these.

For the comment (Although, that EventHubs one appears misplaced. It should be on the RunAsEmulator method.) I've pushed an update to this PR to move the remarks to the correct method. The 3 I pointed to weren't updated in #6718. But they are updated here now (using the other way).

For the 2 in AzureOpenAIDeployment - you can see on the docs site that it isn't working:

https://learn.microsoft.com/en-us/dotnet/api/aspire.hosting.applicationmodel.azureopenaideployment.skuname?view=dotnet-aspire-9.0

image

sebastienros commented 13 hours ago

Thanks. The missing resolution in the docs site is probably something to fix in the docs generation, and if we can't then we may want to change this in the code and remove these substitutions.

I checked for the tags and they don't work either, assuming that the docs are based on release/9.0 and not main.

@IEvangelist do you think there is a possibility this gets fixed in the docs.