dotnet / aspnet-api-versioning

Provides a set of libraries which add service API versioning to ASP.NET Web API, OData with ASP.NET Web API, and ASP.NET Core.
MIT License
3.06k stars 703 forks source link

Add support for odata v9 #1108

Open arabelaa opened 2 months ago

arabelaa commented 2 months ago

Add support for Microsoft.AspNetCore.OData v9

Summary of the changes (Less than 80 chars)

Description

Issue ref: https://github.com/dotnet/aspnet-api-versioning/issues/1103

With the release of Microsoft.AspNetCore.OData 9 https://devblogs.microsoft.com/odata/announcing-asp-net-core-odata-9-official-release/, I thought it's time to have support in aspnet-api-versioning.

arabelaa commented 2 months ago

@dotnet-policy-service agree company="UiPath"

arabelaa commented 2 months ago

@commonsensesoftware can you please have a look?

ct-jby commented 3 weeks ago

Can someone review and merge please ?

We'd like to be able to use odata v9 with api versioning

mike-bagheri commented 3 weeks ago

Can someone please merge this PR

commonsensesoftware commented 3 weeks ago

Apologies for the delay. I've been a bit backed up by my day job and personal life of late. To be clear, I am the someone to review and merge the change. This entire repo from code to docs is managed by a single person - me (and always has been).

I appreciate the urgency and ❤️ that someone has put forth the effort to create a PR. Honestly, that's pretty infrequent in this repo. I need to spend some time to consider the full impact; especially, since this PR intends to bump the major version. .NET 9 is just around the corner and I'd prefer that all the major version numbers line up, even though I realize OData doesn't release on the standard cadence. If OData was more stable, I'd leave the major version open, which may have negated this change; however, I've been bitten by its breaking changes countless times.

You're not being ignored. Releases need to be of the highest quality. My mental plan of action is as follows:

I'll do what I can to carve out some time over the next days to flush things out get this change rolling forward. Thanks for your patience.