Using SignalR core with Unity and IL2CPP (AOT)

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.

https://asp.net

MIT License

35.18k stars 9.93k forks source link

Using SignalR core with Unity and IL2CPP (AOT) #12102

Open thorgeirk11 opened 5 years ago

thorgeirk11 commented 5 years ago

I am having a similar issue as #10080. I am using preview 6 of asp.net core SignalR client inside of unity and compiling with IL2CPP. I created a small git repo with the code I use to reproduce this issue

I am running into an exception when starting the connection:

connection = new HubConnectionBuilder()
   .WithUrl("http://localhost:5000/gamehub")
   .Build(); // works fine

await connection.StartAsync(); // takes a few sec before failing

The connection.StartAsync fails with the following exception:

InvalidDataException: Missing required property 'connectionId'.
  at Microsoft.AspNetCore.Http.Connections.NegotiateProtocol.ParseResponse (System.ReadOnlySpan`1[T] content)

Unity's IL2CPP strips unused assemblies. It caused another issue but I fixed that by adding link.xml file. So the issue described here should not be affected by code stripping.

Here are the server and client traces.

davidfowl commented 3 years ago

We never attempted to make unity work with the default SignalR client, especially not with IL2CPP. It's not on the list for .NET 6 and we're near the end. Unless it's a trivial fix, this won't be something that we work on for the upcoming release.

youtpout commented 3 years ago

Finally I buy a plugin on asset store for call SignalR with Messagepack on IL2CPP. But you can use SignalR with Json without problem on IL2CPP.

thorgeirk11 commented 3 years ago

@davidfowl we would highly appreciate you giving it a chance. @neuecc would you be willing to give them a hand?

This issue doesn't sound as a major effort. The heavy lifting has already been done the MessagePack Generator. Can you have someone investigate if this could be fixed in the coming release?

BrennanConroy commented 3 years ago

If there is a trivial fix, then someone could try it out by copying the MessagePackHubProtocol and worker, modify it with the fix, then try it out on the client.

class MyCustomHubProtocol : IHubProtocol
{
    // modified from MessagePackHubProtocol
}

hubConnectionBuilder.Services.TryAddEnumerable(ServiceDescriptor.Singleton<IHubProtocol, MyCustomHubProtocol>());

We don't have any cycles during the last leg of .NET 6 to work on this.

ghost commented 3 years ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.