Consolidate IRequestBodyPipeFeature and IHttpRequestFeature.Body

[Tratcher]

For 3.0.0-preview8 we consolidated all of the response body APIs onto the new IHttpResponseBodyFeature. We should do something similar for request bodies to make them more reliable to shim.

New API: IHttpRequestBodyFeature

• Stream
• PipeReader
• DisableBuffering - Maybe we don't need to bring this one back. We obsoleted IHttpBufferingFeature and nobody was using DisableRequestBuffering. It's more common for people to want to enable buffering since we don't by default.

Obsolete: IRequestBodyPipeFeature IHttpRequestFeature.Body

https://github.com/aspnet/AspNetCore/blob/master/src/Http/Http.Features/src/IRequestBodyPipeFeature.cs https://github.com/aspnet/AspNetCore/blob/master/src/Http/Http/src/Features/RequestBodyPipeFeature.cs

This isn't as high a priority as it was for response bodies because there are fewer APIs, the auto-adapters work better for the read scenario, and it's less common to shim the request body.

[davidfowl]

@anurse I just realized we left the IRequestBodyPipeFeature which is super unfortunate. Is there any chance we can rectify this? It leaves us into a bit of limbo as that feature will likely be deprecated in a later release...

[ghost]

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s). If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.