search

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.37k stars 9.99k forks source link

[Templating] Update the SPA templates to use generic host #15349

Closed javiercn closed 4 years ago

javiercn commented 5 years ago
javiercn commented 5 years ago

https://github.com/aspnet/AspNetCore/issues/15060

javiercn commented 5 years ago

We should do this for 3.1 I think.

https://github.com/aspnet/AspNetCore/blob/release/3.1/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/Angular-CSharp/Program.cs#L19-L21 https://github.com/aspnet/AspNetCore/blob/release/3.1/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/React-CSharp/Program.cs#L19-L21 https://github.com/aspnet/AspNetCore/blob/release/3.1/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/Program.cs#L20-L22

/cc: @davidfowl thoughts?

danroth27 commented 5 years ago

@javiercn Is there any reason we didn't do this in 3.0?

javiercn commented 4 years ago

@danroth27 We missed it?

danroth27 commented 4 years ago

Cool, if there's no technical reason not to do this then I agree we should just get this done in 3.1.

javiercn commented 4 years ago

It's already done. Waiting for someone to sign-off the PR.