Open DataJuggler opened 4 years ago
@blowdart @ajcvickers so if we want to add UI options, this prob would end up looking like the following:
so for this specific issue, we could do something like:
services.AddDefaultIdentity(o => o.UI.ShowExternalLogins = false)
This would result in the UI pages just not showing the relevant sections, it would not prevent the handler code from working or anything else, it would just cause rending changes on Login and Manage.
Does that sound reasonable?
Alternatively, this does just work via the normal, scaffold, and delete the elements from the layout, which is the general idea...
Folks don't want to scaffold and who can blame them?
I like the idea of UI properties, it's more future proof. If you're going to set that to true, but also configure logins I'd assume you were doing something yourself in your UI elsewhere.
"There are no external authentication services configured." should also be considered worth fixing.
The packaged template pages display the message when there are no oAuth services configured. E.g. when the Web App does not actually need oAuth and is using their own local auth Identity database.
The updated page templates from original v4 "Identity" project have an IF around the required section.
Will the latest templates be imported?
https://github.com/dotnet/aspnetcore/issues/30305 has another approach we should consider as part of the work.
As this is something not many seem to need, how would one achieve this without a new feature?
The Identity Server v4 UI original code, has an @if (Model.VisibleExternalProviders.Any())
Is there another project to rebase from? This repo pages is missing out on new features from Identity Server 4 Quickstart.
Thanks for contacting us.
We're moving this issue to the .NET 8 Planning
milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.
I read several posts on stackoverflow that you cannot remove the part that says 'Use Another Service To Login.' If you do not agree with the privacy policy of any of the other services, my only choice is to write my own authentication, or show a message 'Use Another Service To Login'.
The link to the page in the article that explains how to setup up another service, does not show how to opt out of using another service. For an open source project, the built in login is fine.
I read the 'How To Scaffold A Razor Page Article someone suggested, but a simple 'ShowExternalProviderMessage' would be much simpler.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Example: I am trying to do [...] but [...]
Describe the solution you'd like
A clear and concise description of what you want to happen. Include any alternative solutions you've considered.
Additional context
Add any other context or screenshots about the feature request here.