search

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.47k stars 10.03k forks source link

Upgrade to the latest Bootstrap version #19225

Closed mkArtakMSFT closed 3 years ago

mkArtakMSFT commented 4 years ago

There were several breaking changes in Bootstrap 4 (from Bootstrap 3) which we also need to react to as part of this upgrade.

This issue will also be used to track all related work to the bootstrap 5 update:

KKacer commented 4 years ago

I think Bootstrap was past! By the all recent changes and news in CSS, there is no need for bootstrap. tying more and more the platform and components to a 3rd party library will add more time and hassle for people who try to make more pure or more customized things. I believe BootStrap was past though Blazor can be the future. So if possible while you try to consider the needs of web newbies, consider 1 extra scenario without Bootstrap, Materialize, and font-awesome, Jquery things, which none of them are standards, they may make a buzz for a period and then be gone, and each person can have it's own choice or custom scenario. So personally I suggest not invest on bootsrap much, just may be there as an option, instead invest more on the standards. Like considering CSS Grid, FlexBox, ...

mkArtakMSFT commented 4 years ago

Thanks for your feedback @KKacer. We'll definitely think about these points you've mentioned when we will get to handling this issue.

mkArtakMSFT commented 4 years ago

Related https://github.com/dotnet/aspnetcore/issues/23017

ghost commented 4 years ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

ghost commented 3 years ago

Thanks for contacting us. We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

HaoK commented 3 years ago

Met today and we agreed on a plan of record for identity ui for 6.0:

cc @danroth27 @blowdart @DamianEdwards @javiercn @pranavkm @mkArtakMSFT @adityamandaleeka

HaoK commented 3 years ago

Bootstrap 5.0.2 has been merged in https://github.com/dotnet/aspnetcore/pull/34052

Still need follow up PR to add back the ability to switch back to V4

HaoK commented 3 years ago

@deepchoudhery we have updated to bootstrap5 for net6.0 by default, can you help identify what changes need to go into https://github.com/dotnet/Scaffolding/tree/main/src/Scaffolding/VS.Web.CG.Mvc/Templates/Identity/Bootstrap4/wwwroot for the scaffolding side of things?

deepchoudhery commented 3 years ago

Yes, I'll add an item to track for 6.0-rc1. I'll follow up soon.

DamianEdwards commented 3 years ago

@HaoK just used the updated templates for the first time and noticed a few spacing/margin issues. Are these known and being fixed? e.g. image

HaoK commented 3 years ago

Yeah @blowdart just went over them for me, we think its just a matter of removing the form-group, I will have a PR open for this today soon, I'll add you to the review

HaoK commented 3 years ago

https://github.com/dotnet/aspnetcore/pull/35197

HaoK commented 3 years ago

Looks like @deepchoudhery merged the scaffolding side of things today 🎉