dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.52k stars 10.04k forks source link

Remove ServerSentEvents transport #20462

Closed BrennanConroy closed 3 years ago

BrennanConroy commented 4 years ago

We should look into removing the ServerSentEvents transport. Now that WebSockets is more common place, and LongPolling with HTTP/2 is also more common (and fast), SSE isn't needed. Plus SSE doesn't support binary.

We probably don't want to remove the implementation from the server, and we can't remove it from the negotiate response, otherwise old clients could break when used with a newer server.

We can remove the transport from all clients (TS and .NET).

Semi related: https://github.com/dotnet/aspnetcore/issues/12662

davidfowl commented 4 years ago

We should look into removing the ServerSentEvents transport. Now that WebSockets is more common place, and LongPolling with HTTP/2 is also more common (and fast), SSE isn't needed. Plus SSE doesn't support binary.

We need to measure before we remove.

davidfowl commented 3 years ago

Nah