search

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.35k stars 9.99k forks source link

Backport Microsoft.AspNetCore.WebUtilities.QueryHelpers fix from master to next maintenance releases? #24239

Closed IanKemp closed 4 years ago

IanKemp commented 4 years ago

This file has a fix on master https://github.com/dotnet/aspnetcore/blob/master/src/Http/WebUtilities/src/QueryHelpers.cs#L134 that is not present in the currently released versions of ASP.NET Core e.g. https://github.com/dotnet/aspnetcore/blob/v3.1.6/src/Http/WebUtilities/src/QueryHelpers.cs

If this is something the team thinks would add value, I'd be happy to submit a PR to backport this fix (incl tests) in 3.1.next and 2.1.next, but not sure how that would work with respect to from where I should branch and to where the PR should be set to merge into.

Pilchie commented 4 years ago

In order to justify servicing, this needs to be a blocking issue without a decent workaround. In this case, it seems like a workaround would be to copy those to your own project.

IanKemp commented 4 years ago

In order to justify servicing, this needs to be a blocking issue without a decent workaround. In this case, it seems like a workaround would be to copy those to your own project.

Understood.