search

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.44k stars 10.02k forks source link

Cancel response buffer copies if the client disconnects. #24813

Open Tratcher opened 4 years ago

Tratcher commented 4 years ago

The response body does not throw exceptions if the client disconnects. It does that to avoid noisy logs for things that weren't the server's fault. However, that means that if the app is doing something that it wants to stop early then it needs to monitor the RequestAborted token.

Example: There's no need to copy this buffer to the response if the client has disconnected. Pass RequestAborted and catch OperationCancelledException for all usages of DrainBufferAsync. https://github.com/dotnet/aspnetcore/blob/ef1f48ab97174131f1753efe9241295b1309d3e2/src/Mvc/Mvc.ViewFeatures/src/ViewComponentResultExecutor.cs#L158

ghost commented 4 years ago

Thanks for contacting us. We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

ghost commented 4 years ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

mkArtakMSFT commented 2 years ago

@Tratcher should we close it given that we haven't done this for so long or do you think this is important and we must try to resolve this?

Tratcher commented 2 years ago

Please fix this in 8.

ghost commented 2 years ago

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s). If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.