search

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.58k stars 10.06k forks source link

Consider increasing SignalR log level if message size exceeds max #26849

Open pranavkm opened 4 years ago

pranavkm commented 4 years ago

In Blazor Server, when a JSInterop response is larger than the SignalR payload size, no information is available by default that indicates the invocation failed. You have to turn up the SignalR logs up to to Debug to see the actual error:

dbug: Microsoft.AspNetCore.SignalR.HubConnectionHandler[2]
      Error when processing requests.
      System.IO.InvalidDataException: The maximum message size of 32768B was exceeded. The message size can be configured in AddHubOptions.

SignalR calls Hub.OnDisconnectedAsync with this exception but Blazor does not do anything with the exception. Perhaps logging the exception with a higher log level would be helpful.

ghost commented 4 years ago

Thanks for contacting us. We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

dannyBies commented 3 years ago

I ran into this issue as well. I would've expected this to be LogLevel.Error. I'd be happy to provide a PR if wanted. https://github.com/dotnet/aspnetcore/blob/23b704915cdb9a73df7a61ff1aaa894712098615/src/SignalR/server/Core/src/HubConnectionHandlerLog.cs#L16-L17

ghost commented 3 years ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

adityamandaleeka commented 3 years ago

Triage: sounds like this needs more discussion. We're not sure there's a good solution.

ghost commented 2 years ago

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s). If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

nlpsl202 commented 7 months ago

I have the same issue, I think all error cause blazor reconnect should be log as error, so we can find what cause this error, but now only debug using visual studio can find out what is going on.