search

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.2k stars 9.94k forks source link

Encoder abstraction for SignalR.StackExchangeRedis pub/sub messages #28669

Open tylerohlsen opened 3 years ago

tylerohlsen commented 3 years ago

Problem Description

As pointed out by issue 18074, references to MessagePack are in lock step with ASP.NET Core 3.x and ASP.NET 5. Consumers that want to use MessagePack for their own application use and also use Microsoft.AspNetCore.SignalR.StackExchangeRedis are forced to the same major version of MessagePack. This also means that upgrading to .NET 5 is more challenging for those projects because they may not be ready to perform a major version upgrade of MessagePack.

Proposed Solution

I'd like to see Microsoft.AspNetCore.SignalR.StackExchangeRedis depend on an abstraction for the message encoder used for Redis pub/sub. That would allow us to make adapters to have any version of the SignalR library work with any version of MessagePack. (Similar to how ASP.NET made an abstraction for the json serializer)

ghost commented 3 years ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

BrennanConroy commented 3 years ago

Leaving open to see if there is customer interest.

As of right now we aren't planning on implementing this.