search

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.36k stars 9.99k forks source link

Fix broken links #30886

Open Youssef1313 opened 3 years ago

Youssef1313 commented 3 years ago

See GitHub Action run in https://github.com/dotnet/aspnetcore/pull/30885

*Let me know if there are any false positives.

Summary of the results:

+ Validating links in: /github/workspace/CONTRIBUTING.md.
- ##[error]Invalid link: '/docs/README.md' relative to '/github/workspace'.

+ Validating links in: /github/workspace/docs/BuildFromSource.md.
- ##[error]Invalid link: '/eng/scripts/InstallVisualStudio.ps1' relative to '/github/workspace/docs'.
- ##[error]Invalid link: '/global.json' relative to '/github/workspace/docs'.
- ##[error]Invalid link: '/eng/scripts/vs.json' relative to '/github/workspace/docs'.
- ##[error]Invalid link: '/eng/scripts/InstallJdk.ps1' relative to '/github/workspace/docs'.
- ##[error]Invalid link: 'using-dotnet-on-command-line-in-this-repo' relative to '/github/workspace/docs'.

+ Validating links in: /github/workspace/docs/SharedFramework.md.
- ##[error]Invalid link: '/eng/SharedFramework.Local.props' relative to '/github/workspace/docs'.
- ##[error]Invalid link: '/eng/SharedFramework.External.props' relative to '/github/workspace/docs'.

+ Validating links in: /github/workspace/docs/ReferenceResolution.md.
- ##[error]Invalid link: '/eng/targets/ResolveReferences.targets' relative to '/github/workspace/docs'.
- ##[error]Invalid link: '/eng/tools/BaselineGenerator/README.md' relative to '/github/workspace/docs'.
- ##[error]Invalid link: '/eng/Baseline.xml' relative to '/github/workspace/docs'.
- ##[error]Invalid link: 'eng/Baseline.Designer.props' relative to '/github/workspace/docs'.
- ##[error]Invalid link: '/eng/Dependencies.props' relative to '/github/workspace/docs'.
- ##[error]Invalid link: '/eng/ProjectReferences.props' relative to '/github/workspace/docs'.
- ##[error]Invalid link: '/eng/Versions.props' relative to '/github/workspace/docs'.
- ##[error]Invalid link: '/eng/Version.Details.xml' relative to '/github/workspace/docs'.
- ##[error]Invalid link: '/eng/Versions.props' relative to '/github/workspace/docs'.
- ##[error]Invalid link: 'global.json' relative to '/github/workspace/docs'.
- ##[error]Invalid link: '/eng/Dependencies.props' relative to '/github/workspace/docs'.
- ##[error]Invalid link: '/eng/Versions.props' relative to '/github/workspace/docs'.
- ##[error]Invalid link: '/eng/Version.Details.xml' relative to '/github/workspace/docs'.

+ Validating links in: /github/workspace/docs/PreparingPatchUpdates.md.
- ##[error]Invalid link: '/eng/Versions.props' relative to '/github/workspace/docs'.
- ##[error]Invalid link: '/eng/tools/BaselineGenerator/README.md' relative to '/github/workspace/docs'.

+ Validating links in: /github/workspace/src/Tools/README.md.
- ##[error]Invalid link: 'dotnet-watch/README.md' relative to '/github/workspace/src/Tools'.

+ Validating links in: /github/workspace/src/Html.Abstractions/README.md.
- ##[error]Invalid link: '../../../BuildFromSource.md#building-a-subset-of-the-code' relative to '/github/workspace/src/Html.Abstractions'.
- ##[error]Invalid link: '../../../BuildFromSource.md#running-tests-on-command-line' relative to '/github/workspace/src/Html.Abstractions'.
- ##[error]Invalid link: '../../../README.md' relative to '/github/workspace/src/Html.Abstractions'.

+ Validating links in: /github/workspace/src/Middleware/WebSockets/README.md.
- ##[error]Invalid link: './test/AutobahnTestApp/README.md' relative to '/github/workspace/src/Middleware/WebSockets'.

+ Validating links in: /github/workspace/src/Shared/ErrorPage/README.md.
- ##[error]Invalid link: '/src/Razor/tools/RazorSyntaxGenerator/' relative to '/github/workspace/src/Shared/ErrorPage'.

+ Validating links in: /github/workspace/src/SignalR/docs/GettingStarted.md.
- ##[error]Invalid link: '/docs/BuildFromSource.md' relative to '/github/workspace/src/SignalR/docs'.

+ Validating links in: /github/workspace/eng/tools/BaselineGenerator/README.md.
- ##[error]Invalid link: '/eng/Baseline.xml' relative to '/github/workspace/eng/tools/BaselineGenerator'.

+ Validating links in: /github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/React-CSharp/ClientApp/README.md.
- ##[error]Invalid link: '../config/webpack.config.prod.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/React-CSharp/ClientApp'.
- ##[error]Invalid link: '../config/webpack.config.prod.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/React-CSharp/ClientApp'.

+ Validating links in: /github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/ClientApp/README.md.
- ##[error]Invalid link: 'src/index.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/ClientApp'.
- ##[error]Invalid link: 'src/index.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/ClientApp'.
- ##[error]Invalid link: 'src/registerServiceWorker.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/ClientApp'.
- ##[error]Invalid link: 'src/registerServiceWorker.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/ClientApp'.
- ##[error]Invalid link: '../config/webpack.config.prod.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/ClientApp'.
- ##[error]Invalid link: '../config/webpack.config.prod.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/ClientApp'.
Youssef1313 commented 3 years ago

The above results containing a fair amount of false positives that needs to be fixed in the GH Action. However, there are indeed some invalid links, including (but not a complete list):

+ Validating links in: /github/workspace/docs/BuildFromSource.md.
- ##[error]Invalid link: 'using-dotnet-on-command-line-in-this-repo' relative to '/github/workspace/docs'.

+ Validating links in: /github/workspace/docs/ReferenceResolution.md.
- ##[error]Invalid link: 'eng/Baseline.Designer.props' relative to '/github/workspace/docs'.
- ##[error]Invalid link: 'global.json' relative to '/github/workspace/docs'.
Youssef1313 commented 3 years ago

Following is an updated output after fixing the GH Action:

+ Validating links in: /github/workspace/docs/BuildFromSource.md.
- ##[error]Invalid link: 'using-dotnet-on-command-line-in-this-repo' relative to '/github/workspace/docs'.

+ Validating links in: /github/workspace/docs/ReferenceResolution.md.
- ##[error]Invalid link: 'eng/Baseline.Designer.props' relative to '/github/workspace/docs'.
- ##[error]Invalid link: 'global.json' relative to '/github/workspace/docs'.

+ Validating links in: /github/workspace/src/Tools/README.md.
- ##[error]Invalid link: 'dotnet-watch/README.md' relative to '/github/workspace/src/Tools'.

+ Validating links in: /github/workspace/src/Html.Abstractions/README.md.
- ##[error]Invalid link: '../../../BuildFromSource.md#building-a-subset-of-the-code' relative to '/github/workspace/src/Html.Abstractions'.
- ##[error]Invalid link: '../../../BuildFromSource.md#running-tests-on-command-line' relative to '/github/workspace/src/Html.Abstractions'.
- ##[error]Invalid link: '../../../README.md' relative to '/github/workspace/src/Html.Abstractions'.

+ Validating links in: /github/workspace/src/Middleware/WebSockets/README.md.
- ##[error]Invalid link: './test/AutobahnTestApp/README.md' relative to '/github/workspace/src/Middleware/WebSockets'.

+ Validating links in: /github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/React-CSharp/ClientApp/README.md.
- ##[error]Invalid link: '../config/webpack.config.prod.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/React-CSharp/ClientApp'.
- ##[error]Invalid link: '../config/webpack.config.prod.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/React-CSharp/ClientApp'.

+ Validating links in: /github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/ClientApp/README.md.
- ##[error]Invalid link: 'src/index.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/ClientApp'.
- ##[error]Invalid link: 'src/index.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/ClientApp'.
- ##[error]Invalid link: 'src/registerServiceWorker.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/ClientApp'.
- ##[error]Invalid link: 'src/registerServiceWorker.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/ClientApp'.
- ##[error]Invalid link: '../config/webpack.config.prod.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/ClientApp'.
- ##[error]Invalid link: '../config/webpack.config.prod.js' relative to '/github/workspace/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/ClientApp'.

Should be more accurate now. Let me know if there are still any false positives.