search

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
34.89k stars 9.85k forks source link

SourceLink links are incorrect for submodules #32063

Open mmitche opened 3 years ago

mmitche commented 3 years ago 
The remote server returned an error: (404) Not Found.
        Failed to retrieve https://raw.githubusercontent.com/dotnet/aspnetcore/93fd8baf5f9670f1123cfd73dddb608eca6f59c3/src/submodules/MessagePack-CSharp/src/MessagePack.UnityClient/Assets/Scripts/MessagePack/Utilities.cs
D:\workspace\_work\1\a\signed\shipping\assets\symbols\Microsoft.AspNetCore.App.Runtime.linux-arm.6.0.0-preview.4.21221.10.symbols.nupkg has broken SourceLink links.

These links are incorrect. The links for raw github content for a submodule should point to the other repos' raw content. E.g.

https://raw.githubusercontent.com/aspnet/MessagePack-CSharp/1fd19e6cc1a58bce9153933324164ec80ed560cf/src/MessagePack.UnityClient/Assets/Scripts/MessagePack/Utilities.cs

mmitche commented 3 years ago

This is currently broken in .NET 6, probably all releases.

mmitche commented 3 years ago

/cc @alexperovich @tmat If this happens to be something on the sourcelink tasks side, rather than aspnetcore's

mmitche commented 3 years ago

@dougbu

dougbu commented 3 years ago

This is a known issue @tmat was working on at some point. A bug somewhere in the sourcelink code…

I don't know the current status other than a fix hasn't reached our repo.

tmat commented 3 years ago

I haven't had time to investigate. Busy with Hot Reload.

dougbu commented 3 years ago

I haven't had time to investigate.

Given that and our own resource issues and lack of knowledge in the space, I'm marking this as both External and blocked. Unless something significant changes, this issue is not actionable.

ghost commented 3 years ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

wtgodbe commented 1 year ago

@tmat is this issue still occurring?

tmat commented 1 year ago

IDK