search

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.1k stars 9.91k forks source link

[Perf] SoD Regression in Microsoft.AspNetCore.Components.WebAssembly.dll #35186

Open performanceautofiler[bot] opened 3 years ago

performanceautofiler[bot] commented 3 years ago

Run Information

Architecture x64
OS ubuntu 18.04
Baseline 40ed818e5ecd9f413ca75bb62c2eb4913acbc723
Compare 5aced7eb238ed2dc9e95734ede4be6e11d74dd9c
Diff Diff

Regressions in SOD - New Blazor Template - Publish

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Runtime.CompilerServices.Unsafe.dll.gz](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 1.25 KB 1.23 KB 0.99 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Collections.Concurrent.dll.br](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 6.69 KB 6.57 KB 0.98 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 21.50 KB 19.50 KB 0.91 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.gz](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 10.39 KB 9.37 KB 0.90 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.br](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 9.17 KB 8.33 KB 0.91 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Net.Primitives.dll.br](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 2.50 KB 2.46 KB 0.98 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/dotnet.VERSION.js](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 220.72 KB 218.49 KB 0.99 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/Microsoft.JSInterop.dll.gz](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 15.13 KB 15.51 KB 1.02 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.WebAssembly.dll](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 39.00 KB 41.00 KB 1.05 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/Microsoft.JSInterop.dll.br](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 13.57 KB 13.92 KB 1.03 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/blazor.webassembly.js](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 55.43 KB 56.51 KB 1.02 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/blazor.webassembly.js.br](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 15.52 KB 15.78 KB 1.02 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.WebAssembly.dll.br](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 15.60 KB 16.60 KB 1.06 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/Microsoft.JSInterop.dll](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 33.50 KB 35.00 KB 1.04 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/blazor.webassembly.js.gz](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 17.51 KB 17.83 KB 1.02 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.WebAssembly.dll.gz](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 17.65 KB 18.66 KB 1.06 0.00 True
[SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Runtime.CompilerServices.Unsafe.dll.br](<https://pvscmdupload.blob.core.windows.net/reports/allTestHistory/refs/heads/main_x64_ubuntu 18.04_CompliationMode=wasm_RunKind=blazor_scenarios/SOD%20-%20New%20Blazor%20Template%20-%20Publish.html>) 1.10 KB 1.12 KB 1.02 0.00 True

graph graph graph graph graph graph graph graph graph graph graph graph graph graph graph graph graph Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - New Blazor Template - Publish*'
### Payloads [Baseline]() [Compare]() ### Histogram #### SOD - New Blazor Template - Publish ```log ``` ### Docs [Profiling workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/profiling-workflow-dotnet-runtime.md) [Benchmarking workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/benchmarking-workflow-dotnet-runtime.md)
ghost commented 3 years ago

Tagging subscribers to this area: @GrabYourPitchForks, @dotnet/area-system-memory See info in area-owners.md if you want to be subscribed.

Issue Details
### Run Information Architecture | x64 -- | -- OS | ubuntu 18.04 Baseline | [40ed818e5ecd9f413ca75bb62c2eb4913acbc723](https://github.com/dotnet/runtime/commit/40ed818e5ecd9f413ca75bb62c2eb4913acbc723) Compare | [5aced7eb238ed2dc9e95734ede4be6e11d74dd9c](https://github.com/dotnet/runtime/commit/5aced7eb238ed2dc9e95734ede4be6e11d74dd9c) Diff | [Diff](https://github.com/dotnet/runtime/compare/40ed818e5ecd9f413ca75bb62c2eb4913acbc723...5aced7eb238ed2dc9e95734ede4be6e11d74dd9c) ### Regressions in SOD - New Blazor Template - Publish Benchmark | Baseline | Test | Test/Base | Test Quality | Edge Detector | Baseline IR | Compare IR | IR Ratio | Baseline ETL | Compare ETL -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Runtime.CompilerServices.Unsafe.dll.gz]() | 1.25 KB | 1.23 KB | 0.99 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Collections.Concurrent.dll.br]() | 6.69 KB | 6.57 KB | 0.98 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll]() | 21.50 KB | 19.50 KB | 0.91 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.gz]() | 10.39 KB | 9.37 KB | 0.90 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Private.Runtime.InteropServices.JavaScript.dll.br]() | 9.17 KB | 8.33 KB | 0.91 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Net.Primitives.dll.br]() | 2.50 KB | 2.46 KB | 0.98 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/dotnet.VERSION.js]() | 220.72 KB | 218.49 KB | 0.99 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/Microsoft.JSInterop.dll.gz]() | 15.13 KB | 15.51 KB | 1.02 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.WebAssembly.dll]() | 39.00 KB | 41.00 KB | 1.05 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/Microsoft.JSInterop.dll.br]() | 13.57 KB | 13.92 KB | 1.03 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/blazor.webassembly.js]() | 55.43 KB | 56.51 KB | 1.02 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/blazor.webassembly.js.br]() | 15.52 KB | 15.78 KB | 1.02 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.WebAssembly.dll.br]() | 15.60 KB | 16.60 KB | 1.06 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/Microsoft.JSInterop.dll]() | 33.50 KB | 35.00 KB | 1.04 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/blazor.webassembly.js.gz]() | 17.51 KB | 17.83 KB | 1.02 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/Microsoft.AspNetCore.Components.WebAssembly.dll.gz]() | 17.65 KB | 18.66 KB | 1.06 | 0.00 | True | | | [SOD - New Blazor Template - Publish - pub/wwwroot/_framework/System.Runtime.CompilerServices.Unsafe.dll.br]() | 1.10 KB | 1.12 KB | 1.02 | 0.00 | True | | | ![graph]() ![graph]() ![graph]() ![graph]() ![graph]() ![graph]() ![graph]() ![graph]() ![graph]() ![graph]() ![graph]() ![graph]() ![graph]() ![graph]() ![graph]() ![graph]() ![graph]() [Historical Data in Reporting System]() ### Repro ```cmd git clone https://github.com/dotnet/performance.git python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - New Blazor Template - Publish*' ```
### Payloads [Baseline]() [Compare]() ### Histogram #### SOD - New Blazor Template - Publish ```log ``` ### Docs [Profiling workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/profiling-workflow-dotnet-runtime.md) [Benchmarking workflow for dotnet/runtime repository](https://github.com/dotnet/performance/blob/master/docs/benchmarking-workflow-dotnet-runtime.md)
Author: performanceautofiler[bot]
Assignees: -
Labels: `area-System.Memory`, `untriaged`
Milestone: -
Tohron commented 3 years ago

I noticed a 5% SoD regression in Microsoft.AspNetCore.Components.WebAssembly.dll from 39kB to 41kB. It might bear investigating.

pranavkm commented 2 years ago

Some insights for this available here: https://github.com/dotnet/aspnetcore/pull/36036

ghost commented 2 years ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

ghost commented 8 months ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.