dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.4k stars 10k forks source link

Change 'http' to 'https' in the HttpRequestsComponent.razor example #41346

Closed JeepNL closed 2 years ago

JeepNL commented 2 years ago

Is there an existing issue for this?

Describe the bug

Config: Blazor WASM, ASP.NET 7 preview 3

In the example here : https://github.com/dotnet/aspnetcore/blob/7c1e6d553209741f615628a8fbe3d7d09c0c43b0/src/Components/test/testassets/BasicTestApp/HttpClientTest/HttpRequestsComponent.razor

you'll get the error: "Failed to fetch" with the default URL string? uri = "http://api.icndb.com/jokes/random"; because it should be 'https' (https://api.icndb.com/jokes/random).

Expected Behavior

Return a JSON response from the http(s)://api.icndb.com/jokes/random API

Steps To Reproduce

Run the code: https://github.com/dotnet/aspnetcore/blob/7c1e6d553209741f615628a8fbe3d7d09c0c43b0/src/Components/test/testassets/BasicTestApp/HttpClientTest/HttpRequestsComponent.razor

Exceptions (if any)

No response

.NET Version

.NET 7 preview 3

Anything else?

No response

mkArtakMSFT commented 2 years ago

Thanks for catching this, @JeepNL. Would you like to send a PR to address this? We'd appreciate it.

ghost commented 2 years ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

JeepNL commented 2 years ago

@mkArtakMSFT That would be my first PR ever 😉, but I need to learn how to do that anyway, so I'll try! I need that knowledge for another repo as well, so now is the time.

JeepNL commented 2 years ago

Merged :)

https://github.com/dotnet/aspnetcore/pull/41374