search

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.23k stars 9.95k forks source link

RateLimitingMiddleware test improvements #43298

Open wtgodbe opened 2 years ago

wtgodbe commented 2 years ago

Update https://github.com/dotnet/aspnetcore/blob/main/src/Middleware/RateLimiting/test/RateLimitingMiddlewareTests.cs to use RateLimiterEndpointConventionBuilderExtensions where appropriate (see https://github.com/dotnet/aspnetcore/pull/43053/#discussion_r943681636)

ghost commented 2 years ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

MadL1me commented 1 year ago

@wtgodbe I read https://github.com/dotnet/aspnetcore/pull/43053 and created improvement on rate limiter tests. I hope I did everything right, and I would appreciate if you look at my PR

ladeak commented 11 months ago

Is this still an open issue to be picked up? I see @MadL1me has addressed issues, or anything left to do here @wtgodbe ?

wtgodbe commented 10 months ago

I don't think there's anything more to do here - @adityamandaleeka are there any other improvements the team wants to make in the tests at this point? From the original description of the issue, I believe the original intent was covered by https://github.com/dotnet/aspnetcore/pull/45541