search

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.39k stars 10k forks source link

Blazor Baselines have hardcoded runtime version #44226

Closed TanayParikh closed 1 year ago

TanayParikh commented 2 years ago

it looks like the manifest checks are breaking because 6.0.7->6.0.8 but:

Microsoft.NET.Sdk.BlazorWebAssembly.Tests.BlazorLegacyIntegrationTest60.Publish60Hosted_Works [FAIL]
      Expected root[14] to be Identity: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\wwwroot\_framework\dotnet.6.0.7.[[hash]].js, SourceType: Project, SourceId: BlazorWasmHosted60.Client, ContentRoot: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\publish\wwwroot\, BasePath: /, RelativePath: _framework/dotnet.6.0.7.[[hash]].js, AssetKind: Publish, AssetMode: All, AssetRole: Primary, RelatedAsset: , AssetTraitName: BlazorWebAssemblyResource, AssetTraitValue: native, CopyToOutputDirectory: Never, CopyToPublishDirectory: PreserveNewest, OriginalItemSpec: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\wwwroot\_framework\dotnet.6.0.7.[[hash]].js, but found Identity: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\wwwroot\_framework\dotnet.6.0.8.[[hash]].js, SourceType: Project, SourceId: BlazorWasmHosted60.Client, ContentRoot: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\publish\wwwroot\, BasePath: /, RelativePath: _framework/dotnet.6.0.8.[[hash]].js, AssetKind: Publish, AssetMode: All, AssetRole: Primary, RelatedAsset: , AssetTraitName: BlazorWebAssemblyResource, AssetTraitValue: native, CopyToOutputDirectory: Never, CopyToPublishDirectory: PreserveNewest, OriginalItemSpec: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\wwwroot\_framework\dotnet.6.0.8.[[hash]].js.
      Expected root[15] to be Identity: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\obj\Debug\net6.0\compress\[[_framework/dotnet.6.0.7.[[hash]].js.br]], SourceType: Project, SourceId: BlazorWasmHosted60.Client, ContentRoot: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\publish\wwwroot\, BasePath: /, RelativePath: _framework/dotnet.6.0.7.[[hash]].js.br, AssetKind: Publish, AssetMode: All, AssetRole: Alternative, RelatedAsset: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\wwwroot\_framework\dotnet.6.0.7.[[hash]].js, AssetTraitName: Content-Encoding, AssetTraitValue: br, CopyToOutputDirectory: Never, CopyToPublishDirectory: PreserveNewest, OriginalItemSpec: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\wwwroot\_framework\dotnet.6.0.7.[[hash]].js, but found Identity: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\obj\Debug\net6.0\compress\[[_framework/dotnet.6.0.8.[[hash]].js.br]], SourceType: Project, SourceId: BlazorWasmHosted60.Client, ContentRoot: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\publish\wwwroot\, BasePath: /, RelativePath: _framework/dotnet.6.0.8.[[hash]].js.br, AssetKind: Publish, AssetMode: All, AssetRole: Alternative, RelatedAsset: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\wwwroot\_framework\dotnet.6.0.8.[[hash]].js, AssetTraitName: Content-Encoding, AssetTraitValue: br, CopyToOutputDirectory: Never, CopyToPublishDirectory: PreserveNewest, OriginalItemSpec: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\wwwroot\_framework\dotnet.6.0.8.[[hash]].js.
      Expected root[16] to be Identity: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\obj\Debug\net6.0\build-gz\[[_framework/dotnet.6.0.7.[[hash]].js.gz]], SourceType: Project, SourceId: BlazorWasmHosted60.Client, ContentRoot: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\publish\wwwroot\, BasePath: /, RelativePath: _framework/dotnet.6.0.7.[[hash]].js.gz, AssetKind: Publish, AssetMode: All, AssetRole: Alternative, RelatedAsset: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\wwwroot\_framework\dotnet.6.0.7.[[hash]].js, AssetTraitName: Content-Encoding, AssetTraitValue: gzip, CopyToOutputDirectory: Never, CopyToPublishDirectory: PreserveNewest, OriginalItemSpec: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\obj\Debug\net6.0\build-gz\[[_framework/dotnet.6.0.7.[[hash]].js.gz]], but found Identity: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\obj\Debug\net6.0\build-gz\[[_framework/dotnet.6.0.8.[[hash]].js.gz]], SourceType: Project, SourceId: BlazorWasmHosted60.Client, ContentRoot: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\publish\wwwroot\, BasePath: /, RelativePath: _framework/dotnet.6.0.8.[[hash]].js.gz, AssetKind: Publish, AssetMode: All, AssetRole: Alternative, RelatedAsset: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\bin\Debug\net6.0\wwwroot\_framework\dotnet.6.0.8.[[hash]].js, AssetTraitName: Content-Encoding, AssetTraitValue: gzip, CopyToOutputDirectory: Never, CopyToPublishDirectory: PreserveNewest, OriginalItemSpec: C:\h\w\9FA408D9\t\dotnetSdkTests\et2ui2sc.td0\Publish60Host---0200F604\Client\obj\Debug\net6.0\build-gz\[[_framework/dotnet.6.0.8.[[hash]].js.gz]].
  1. A hard coded version check in for 6.0.x is extremely fragile
  2. In reality that version should really probably be 6.0.9 see https://github.com/dotnet/installer/pull/14488

cc @dougbu

Originally posted by @lewing in https://github.com/dotnet/sdk/issues/27741#issuecomment-1246140170

dotnet-issue-labeler[bot] commented 2 years ago

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

lewing commented 2 years ago

to be explicit, this the 6.0.x version will change with every servicing release (monthly) so the explicit version will break monthly as well

javiercn commented 1 year ago

Fixed on main as part of https://github.com/dotnet/sdk/commit/45d4a57b7ab3bb0e40c1b418f5ce8433f749f730

https://github.com/dotnet/sdk/pull/29120 https://github.com/dotnet/sdk/pull/29119