Fix template tests to run in CI

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.

https://asp.net

MIT License

35.37k stars 9.99k forks source link

Fix template tests to run in CI #46430

Closed TanayParikh closed 3 months ago

TanayParikh commented 1 year ago

Following tests are failing in the CI only (works fine locally), seems to be due to searching for the StaticFiles dependency. Unclear what exactly is pulling this dependency.

[ ] BlazorWasmHostedTemplate_Works
[ ] BlazorServerTemplate_IdentityWeb_BuildAndPublish
[ ] BlazorWasmHostedTemplate_IndividualAuth_Works_WithLocalDB
[ ] BlazorWasmHostedTemplate_IndividualAuth_Works_WithOutLocalDB

TanayParikh commented 1 year ago

https://dev.azure.com/dnceng-public/public/_build/results?buildId=158385&view=results

wtgodbe commented 1 year ago

Fixed by https://github.com/dotnet/aspnetcore/pull/45682

halter73 commented 1 year ago

We missed one:

https://github.com/dotnet/aspnetcore/blob/f9121bc3e976ec40a959818451d126d5126ce868/src/ProjectTemplates/test/Templates.Blazor.Tests/BlazorWasmTemplateTest.cs#L62-L65

We also skip the only other Playwright test in the entire assembly:

https://github.com/dotnet/aspnetcore/blob/f9121bc3e976ec40a959818451d126d5126ce868/src/ProjectTemplates/test/Templates.Blazor.Tests/BlazorWasmTemplateTest.cs#L26-L28

That issue is at least open, but it says the test is "Quarantined" when in fact it's really skipped.

MackinnonBuck commented 3 months ago

Resolved by #54606