search

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.17k stars 9.93k forks source link

Improve CodeCheck.ps1 experience for API changes during RCs #50635

Open wtgodbe opened 12 months ago

wtgodbe commented 12 months ago

We could fix the API file check in CodeCheck.ps1 so that it doesn't fail in RCs: https://github.com/dotnet/aspnetcore/blob/3c93dc70a17b25b060651cbd4b6379217a58973d/eng/scripts/CodeCheck.ps1#L242

We can do this by only firing off errors when StabilizePackageVersion is true

ghost commented 12 months ago

Thanks for contacting us.

We're moving this issue to the .NET 9 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s). If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.