Automate GPG signing of Java Package

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.

https://asp.net

MIT License

35.4k stars 10k forks source link

Automate GPG signing of Java Package #5309

Open analogrelay opened 6 years ago

analogrelay commented 6 years ago

[x] Integrate into build.cmd with automatic skipping when Java is not present (#2678)
- I think we should try to fail the build if Java is not present when on the CI though to avoid accidentally forgetting to build it because we spun up a new agent and didn't install Java.
- Stretch goal: Acquire Java as part of the build (only on CI)
[x] Make sure VSTS and Jenkins agents have the necessary JDK installed
[x] Make sure TeamCity (if we're still using it by then ;)) has the necessary JDK installed.
[x] Integrate JAR signing into the build
~~Publish packages to a MyGet Maven feed as part of the build on the CI~~ (moved to https://github.com/aspnet/AspNetCore/issues/12025)
[ ] Integrate GPG signing into build
[ ] Consider publishing packages to Maven Central Staging feed as part of build.

analogrelay commented 6 years ago

The remaining work for this is P3 for 2.2. We should do it for 3.0, but it doesn't need to hold up 2.2

analogrelay commented 6 years ago

Assigning to me to document the manual shipping procedures for 2.2. Will bump priority down and move the rest to 3.0 after that.

analogrelay commented 6 years ago

Documented. Automation will have to wait until I have some cycles, which won't be in 2.2

ryanbrandenburg commented 5 years ago

Ping on this. It seems like every time Java updates we're broken by this in one way or another (JAVA_HOME is not updated, or even ALL versions of java are removed).

analogrelay commented 5 years ago

@mikaelm12

analogrelay commented 5 years ago

Triage decision: This isn't necessary to ship the actual Java client artifact, just to make our lives a little less manual.

ghost commented 4 years ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

davidfowl commented 3 years ago

@BrennanConroy this still manual?

BrennanConroy commented 3 years ago

Yes, we have it as part of our release documentation.

davidfowl commented 3 years ago

Is it worth doing this or are we OK having it be manual?