Add Data Protection Metrics

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.

https://asp.net

MIT License

35.37k stars 9.99k forks source link

Add Data Protection Metrics #54451

Open amcasey opened 7 months ago

amcasey commented 7 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

No response

Describe the solution you'd like

We should have KestrelMetrics-style metrics for Data Protection. In particular, we should have simple (vs up-down) counters for the most important error conditions, especially key-not-found.

Additional context

No response

gfoidl commented 7 months ago

We should have KestrelMetrics-style metrics for Data Protection.

Did you mean OTEL-style metrics? (😉)

especially key-not-found.

For easier diagnostics should this be expanded to add an (failure) event to Activity.Current?

amcasey commented 7 months ago

For easier diagnostics should this be expanded to add an (failure) event to Activity.Current?

@gfoidl Tell me more? I'm new to OTEL conventions.

amcasey commented 3 months ago

Personally, I think this is the highest ROI telemetry we could add, but there's some concern about whether it should be dotnet-wide or, conversely, whether this offers any value over log querying, so it's on hold for now.