dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.46k stars 10.03k forks source link

Suggestion: Adding Directive #5607

Closed asyncoder closed 2 years ago

asyncoder commented 6 years ago

I'd love to see the ability of supporting also directives, same principle as Angular.

Thanks!

RemiBou commented 6 years ago

Honestly, I think one of the serious advantage of Blazor compared to other frameworks is its simplicity : there is a small amount of concept in the framework (page / component). In the angular world you learn a new one every day (https://angular.io/guide/glossary).

When asking a feature maybe we could tell which case cannot be resolved with the current framework state instead of grabbing concept from others.

Do you have any case in mind where the current framework cannot help you ?

asyncoder commented 6 years ago

I wouldn't say grabbing features from others rather than taking advantages. However, the simplicity and reusing C# skills are one of the reasons that Blazor got my heart :-)

Directives are really powerful when you want for example to extend new features and behaviours to an existing components. Let's say that you have a native component "input" and you'd like it behaves somehow when the user focus on it. It wouldn't be so nice to create a new abstract component to do this and then you have to manage all others attributes including accessibility and so on.

Hope I made it clear.

Happy blazoring!

srowan commented 6 years ago

Agree, some concept of attribute directives (aka custom bindings in knockout) is critical. Components are good, but they don't go nearly far enough.

asyncoder commented 5 years ago

Any chance to have this feature ASAP? 🙄 @danroth27

danroth27 commented 5 years ago

@asyncoder This one is a bit further down our backlog right now. We need to first land getting the basics of Razor Components into ASP.NET Core 3.0. But if anyone wants to submit some design proposals for what cross cutting directives in Blazor might look like that would be fine.

didii commented 5 years ago

So I'd like to simply give some input about what I like and don't like about the general use of directives and how I feel would be a good investment:

Feel free to comment or criticise.

didii commented 5 years ago

@RemiBou why directives are sometimes preferred:

I want to extend the <select> attribute such that you can use it like this: <select Items="@_items" Changed="@OnChanged"/> Expected behavior is that options are generated automatically based on the collection _items and that I get notified and get the object back from this select rather than an ID as a string (i.e. OnChanged is an Action<TItem>).

This can still be easily implemented using a component. But now I want to style it and add the class attribute to the select. Blazor/Razor will now complain that the parameter class is not defined. Well, I could write a parameter class in the component to support this. But then I want to be able to hide it using the hidden attribute. So you'll have to add that paramter too etc.

This is the result of blazor components not existing in the DOM itself. Which keeps the DOM clean and readable, but now in this case also results in some responsibilities shifted to a child component since the parent has no way of editing it, or a lot of code needs to be added to the child component to support it. Both are not preferred in this case.

RemiBou commented 5 years ago

@chanan found a workaround on the blazorstrap repo here https://github.com/chanan/BlazorStrap/blob/master/src/BlazorStrap/DynamicElement.cs

It's used here https://github.com/chanan/BlazorStrap/blob/d771191f7572aae1aba540c8f87fe81695a621d5/src/BlazorStrap/Progress.cshtml

Liero commented 4 years ago

@didii:

  • They should be succinct

    • Angular directives can add as many parameters as they like. This eventually gives an overload of attributes and it gets hard to identify what attributes belongs to which component/directive. Does [message] belong to the directive of the component? <app-show-message appConfirm [message]="'Are you sure?'">Blah<app-show-message/>
    • Proposal: Only allow a single options object per directive: <MyComponent @MyDirective="@_myDirectiveOptions">
    • Note that if from the previous block proposal 2 is possible, this is obsolete since we simply apply how attributes normally get their options and adding multiple is also the same. This keeps them nicely seperated and easy to understand. @[MyDirective("message", Title = "Tile")] @[MyOtherDirective] <input/>

What about following?

<MyComponent @MyDirective(option1, option2)>
<MyComponent @MyDirective="(option1, option2)">
gojanpaolo commented 3 years ago

In Angular, we've used ng2-trim-directive which lets us trim user inputs neatly like so:

<input trim="blur">

Hoping to get something similar with Blazor

Closest I got so far is..

<input @bind="Foo" onblur="this.value=this.value.trim()">
TonyLugg commented 3 years ago

I switched from Angular to Aurelia a few years ago because of Aurelia's simplicity. Aurelia has "Custom Attributes" which allows you to add behavior to any element in the DOM. The Blazor team should look at how Aurelia implements this as it is simple and intuitive. http://aurelia.io/docs/templating/custom-attributes

Gopichandar commented 3 years ago

Is there any plan for this in near feature. ?

rekna1 commented 3 years ago

I would also strongly favor the possibility to be able to add behavior to existing html elements :

It is preferred when possible to use existing html elements over custom elements to keep html as close to the standard as possible. Input elements should remain input elements ... buttons should remain buttons.

Main problem is, when you wrap eg. a button inside a custom button component, you have to expose almost every aspect of an html button element to be as flexible as possible (properties and events). Also , you'd be more future proof, when html adds new attributes/properties/events, you would be able to use them, which is not the case when the button is wrapped inside a component. (and when this custom component is not under your control you have to wait until the external library updates)

ghost commented 3 years ago

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

rekna1 commented 3 years ago

I don't know for sure, but suppose you have an input element wrapped inside a component, and this component is inside a fieldset. When the fieldset is set to disabled, the component should be disabled as well... Could be more difficult.

I also wonder about aria attributes, custom styling, ... which maybe would require additional coding ...

PavloParafiloCricut commented 2 years ago

Nice feature to have. Can help to avoid nesting hell and workarounds. Should help to organize code better.

ParadiseFallen commented 2 years ago

This will also helps MBB. +1 on this feature

vgb1993 commented 2 years ago

Sounds like a reasonable proposition to me, I think directives can help you organize better and improve readability

justdox commented 2 years ago

Honestly, I think one of the serious advantage of Blazor compared to other frameworks is its simplicity : there is a small amount of concept in the framework (page / component). In the angular world you learn a new one every day (https://angular.io/guide/glossary).

When asking a feature maybe we could tell which case cannot be resolved with the current framework state instead of grabbing concept from others.

Do you have any case in mind where the current framework cannot help you ?

So, here is a typical case, that is to apply drag-movable feature to any HTML element like that in Angular —— by just attach a directive to the element.

In fact, the so-called "simplicity" is truely Weak, Crude, and NOT Finished. It makes that very hard to achieve AOP, to reuse Common functionality codes.

mkArtakMSFT commented 2 years ago

Thanks for contacting us. This suggestion seems to be too general. We are open to more specific and detailed proposals.

ParadiseFallen commented 2 years ago

@mkArtakMSFT we want attached properties for blazor like in XAML, thats all

mikestam commented 2 years ago

I thought this was already a Blazor feature. Aurelia has great feature and examples of directives. @show, @if, @disabled and whatever you implement. This makes code clean and nice. Easy and intuitive to write and follow. Yes, you can achieve this in different ways in Blazor but do not want to use component to wrap button or div for this, or numerous @if{) nor to use css framework dependent classes. Attached properties could be the way too.

Gaulomatic commented 2 years ago

So this issue, although mentioning Angular 12 times and Aurelia six times, is now closed after .. four years - because it is not too specific. Great job.

TonyLugg commented 2 years ago

@mkArtakMSFT If you just looked at custom attributes in Aurelia like I suggest a long time ago, you would perhaps understand. Custom attributes are somewhat "general", which is what we are all looking for.