search

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
34.84k stars 9.84k forks source link

Push minified .js files to submodule #56472

Open wtgodbe opened 1 week ago

wtgodbe commented 1 week ago

Plan of record to fix the NPM build for source-build in .NET 9:

  1. Push minified .js files to https://github.com/dotnet/BlazorMinifiedJs
  2. Add https://github.com/dotnet/BlazorMinifiedJs as a submodule
  3. In source-build, don't build node/npm components - instead reference the minified .js files from the submodule
  4. Error whenever the files in the submodule don't match what's in the repo
  5. In any PR that would change the contents of the minified .js files, push the updated files to the submodule repo & ingest it in that same PR (so that we are testing changes here at the source, in the same way we would for full .NET source build)

CC @javiercn @dotnet/source-build-contrib

MichaelSimons commented 1 week ago

cc @dotnet/distro-maintainers

tmds commented 1 week ago

cc @Swapnali911 @uweigand @Vishwanatha-HD