dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
34.81k stars 9.84k forks source link

Add named pipes methods to Kestrel configuration loader #56565

Closed JamesNK closed 1 day ago

JamesNK commented 3 days ago

Background and Motivation

Named pipes were added in .NET 8. APIs for named pipes were added across Kestrel, but they were missed on KestrelConfigurationLoader. This proposal closes that gap.

Proposed API

namespace Microsoft.AspNetCore.Server.Kestrel;

public class KestrelConfigurationLoader
{
+    public KestrelConfigurationLoader NamedPipeEndpoint(string pipeName);
+    public KestrelConfigurationLoader NamedPipeEndpoint(string pipeName, Action<ListenOptions> configure);
}

Usage Examples

Alternative Designs

Risks

dotnet-policy-service[bot] commented 3 days ago

Thank you for submitting this for API review. This will be reviewed by @dotnet/aspnet-api-review at the next meeting of the ASP.NET Core API Review group. Please ensure you take a look at the API review process documentation and ensure that:

amcasey commented 2 days ago

API Approved!