dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.54k stars 10.05k forks source link

Perf regression: json_middleware, json_middleware, json_middleware #58114

Open pr-benchmarks[bot] opened 1 month ago

pr-benchmarks[bot] commented 1 month ago
Scenario Environment Date Old RPS New RPS Change Deviation StDev Dependencies
json_middleware Json 5M 1- Trends Intel Windows 09/25/2024 21:30:12 924 598 -35.33 % (-327) :thumbsdown: -253.51 σ 1.29
Changes
NameVersionDiff
Microsoft.AspNetCore.App 9.0.0-rtm.24466.12 -> 9.0.0-rtm.24474.6 https://github.com/dotnet/aspnetcore/compare/0d72ad5e4c5b1394e9708f47ed81e9748e4fd819...afe2857bffef08213d6f3c7688647c60d5d5e7bd
Microsoft.NETCore.App 9.0.0-rc.2.24463.7 -> 9.0.0-rtm.24473.2 https://github.com/dotnet/runtime/compare/46cfb747b4c22471242dee0d106f5c79cf9fd4c5...3d9da91a9720f7bda3e4cef127b8195441fb2580
json_middleware Json 400k 1- Trends Intel Windows 09/25/2024 21:31:04 11,808 11,004 -6.81 % (-805) :thumbsdown: -98.37 σ 8.18
Changes
NameVersionDiff
Microsoft.AspNetCore.App 9.0.0-rtm.24466.12 -> 9.0.0-rtm.24474.6 https://github.com/dotnet/aspnetcore/compare/0d72ad5e4c5b1394e9708f47ed81e9748e4fd819...afe2857bffef08213d6f3c7688647c60d5d5e7bd
Microsoft.NETCore.App 9.0.0-rc.2.24463.7 -> 9.0.0-rtm.24473.2 https://github.com/dotnet/runtime/compare/46cfb747b4c22471242dee0d106f5c79cf9fd4c5...3d9da91a9720f7bda3e4cef127b8195441fb2580
json_middleware Json 5M 2- Trends Intel Linux 09/25/2024 21:51:30 930 677 -27.19 % (-253) :thumbsdown: -393.46 σ 0.64
Changes
NameVersionDiff
Microsoft.AspNetCore.App 9.0.0-rtm.24466.12 -> 9.0.0-rtm.24474.6 https://github.com/dotnet/aspnetcore/compare/0d72ad5e4c5b1394e9708f47ed81e9748e4fd819...afe2857bffef08213d6f3c7688647c60d5d5e7bd
Microsoft.NETCore.App 9.0.0-rc.2.24463.7 -> 9.0.0-rtm.24473.2 https://github.com/dotnet/runtime/compare/46cfb747b4c22471242dee0d106f5c79cf9fd4c5...3d9da91a9720f7bda3e4cef127b8195441fb2580

PowerBI Dashboard

@sebastienros

sebastienros commented 1 month ago

@BrennanConroy Legit. Currently isolating the commits, pinging you because it affects the improvements you got with PipeWriter changes.

BrennanConroy commented 1 month ago

Expected.