search

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.46k stars 10.03k forks source link

autogenerated files by Microsoft Visual C++ that may can be deleted #58632

Open dviererbe opened 1 month ago

dviererbe commented 1 month ago

Describe the Bug

I was running lintian (static analysis tool for deb packages) in pedantic mode and it made suggestion to remove auto generated files from the source. I just wanted to share these remarks here, in case they may be useful. These files seem not to be important for Linux source built.

P: dotnet9 source: source-contains-autogenerated-visual-c++-file [src/aspnetcore/src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/aspnetcoremodule.rc]
P: dotnet9 source: source-contains-autogenerated-visual-c++-file [src/aspnetcore/src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/resource.h]
P: dotnet9 source: source-contains-autogenerated-visual-c++-file [src/aspnetcore/src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/HtmlResponses.rc]
P: dotnet9 source: source-contains-autogenerated-visual-c++-file [src/aspnetcore/src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/inprocessrequesthandler.rc]
P: dotnet9 source: source-contains-autogenerated-visual-c++-file [src/aspnetcore/src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/resource.h]
P: dotnet9 source: source-contains-autogenerated-visual-c++-file [src/aspnetcore/src/Servers/IIS/AspNetCoreModuleV2/OutOfProcessRequestHandler/HtmlResponses.rc]
P: dotnet9 source: source-contains-autogenerated-visual-c++-file [src/aspnetcore/src/Servers/IIS/AspNetCoreModuleV2/OutOfProcessRequestHandler/outofprocessrequesthandler.rc]
P: dotnet9 source: source-contains-autogenerated-visual-c++-file [src/aspnetcore/src/Servers/IIS/AspNetCoreModuleV2/OutOfProcessRequestHandler/resource.h]
P: dotnet9 source: source-contains-autogenerated-visual-c++-file [src/wpf/src/Microsoft.DotNet.Wpf/src/PenImc/dll/resource.h]

Steps to Reproduce

Files in the corresponding repositories:

Other Information

$ lintian-explain-tags source-contains-autogenerated-visual-c++-file
P: source-contains-autogenerated-visual-c++-file
N: 
N:   The following file is autogenerated by Microsoft Visual C++.
N:   
N:   They are usually provided for the convenience of users. These files usually just take up space
N:   in the tarball and are of no use in Debian.
N:   
N:   Check if upstream also provides source-only tarballs that you can use as the upstream
N:   distribution instead. If not, you may want to ask upstream to provide source-only tarballs.
N: 
N:   Visibility: pedantic
N:   Show-Always: no
N:   Check: cruft
MichaelSimons commented 2 weeks ago

Transferring this issue to aspnetcore to get their input on why they check these files in. Will log a separate wpf issue for the one wpf file mentioned.