dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.48k stars 10.03k forks source link

-BuildManaged -BuildInstallers doesn't work as installer build too early #58984

Open ViktorHofer opened 4 hours ago

ViktorHofer commented 4 hours ago

When building installers without first building the rest of the repository (managed + native) in a previous build execution, the build fails as the installer build runs too early. This is probably not a problem as that's not a common workflow but with the VMR we need to be able to build the entire repository in one go.

Blocks https://github.com/dotnet/sdk/pull/44828?new_mergebox=true

The solution that I'm thinking of is adding a Traversal project that builds the installer projects and adding that to eng/Build.props at the very end with a BuildInParallel=false metadata so that it runs after everything else. The installer project will still build in parallel.

ViktorHofer commented 4 hours ago

cc @wtgodbe