dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.42k stars 10k forks source link

[Tooling] Evaluate obsolete APIs from 2.2 and consider removing them in 3.0.0 #7146

Closed Eilon closed 5 years ago

Eilon commented 5 years ago

Here's everything marked obsolete in 'master' in this repo. Please use the links below to compare master and release/2.2 to see if this is a pre-existing obsolete message for a member that can now be deleted. For each item consider whether to log a bug because we will take an action, and then check the checkbox to mark it as done (even if there's no further action).

(1) src\Razor\src\Microsoft.AspNetCore.Mvc.Razor.Extensions\InjectDirective.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static IRazorEngineBuilder Register(IRazorEngineBuilder builder)
        {

(2) src\Razor\src\Microsoft.AspNetCore.Mvc.Razor.Extensions\ModelDirective.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static IRazorEngineBuilder Register(IRazorEngineBuilder builder)
        {

(3) src\Razor\src\Microsoft.AspNetCore.Mvc.Razor.Extensions\NamespaceDirective.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static void Register(IRazorEngineBuilder builder)
        {

(4) src\Razor\src\Microsoft.AspNetCore.Mvc.Razor.Extensions\PageDirective.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static IRazorEngineBuilder Register(IRazorEngineBuilder builder)
        {

(5) src\Razor\src\Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X\InjectDirective.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static IRazorEngineBuilder Register(IRazorEngineBuilder builder)
        {

(6) src\Razor\src\Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X\ModelDirective.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static IRazorEngineBuilder Register(IRazorEngineBuilder builder)
        {

(7) src\Razor\src\Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X\RazorExtensions.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static void Register(IRazorEngineBuilder builder)
        {

(8) src\Razor\src\Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X\RazorExtensions.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static void RegisterViewComponentTagHelpers(IRazorEngineBuilder builder)
        {

(9) src\Razor\src\Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X\InjectDirective.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static IRazorEngineBuilder Register(IRazorEngineBuilder builder)
        {

(10) src\Razor\src\Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X\ModelDirective.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static IRazorEngineBuilder Register(IRazorEngineBuilder builder)
        {

(11) src\Razor\src\Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X\NamespaceDirective.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static void Register(IRazorEngineBuilder builder)
        {

(12) src\Razor\src\Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X\PageDirective.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static IRazorEngineBuilder Register(IRazorEngineBuilder builder)
        {

(13) src\Razor\src\Microsoft.AspNetCore.Razor.Language\IRazorCodeGenerationOptionsFeature.cs

Links: [master] | [release/2.2] File a bug for this

    [Obsolete("In Razor 2.1 and newer, use RazorCodeDocument.GetCodeGenerationOptions().")]
    public interface IRazorCodeGenerationOptionsFeature : IRazorEngineFeature
    {

(14) src\Razor\src\Microsoft.AspNetCore.Razor.Language\IRazorEngineBuilder.cs

Links: [master] | [release/2.2] File a bug for this

    [Obsolete("This class is obsolete and will be removed in a future version. The recommended alternative is " + nameof(RazorProjectEngineBuilder) + ".")]
    public interface IRazorEngineBuilder
    {

(15) src\Razor\src\Microsoft.AspNetCore.Razor.Language\IRazorParserOptionsFeature.cs

Links: [master] | [release/2.2] File a bug for this

    [Obsolete("In Razor 2.1 and newer, use RazorCodeDocument.GetParserOptions().")]
    public interface IRazorParserOptionsFeature : IRazorEngineFeature
    {

(16) src\Razor\src\Microsoft.AspNetCore.Razor.Language\RazorEngine.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static RazorEngine Create()
        {

(17) src\Razor\src\Microsoft.AspNetCore.Razor.Language\RazorEngine.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version. The recommended alternative is " + nameof(RazorProjectEngine) + "." + nameof(RazorProjectEngine.Create))]
        public static RazorEngine Create(Action<IRazorEngineBuilder> configure) => CreateCore(RazorConfiguration.Default, false, configure);

(18) src\Razor\src\Microsoft.AspNetCore.Razor.Language\RazorEngine.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version. The recommended alternative is " + nameof(RazorProjectEngine) + "." + nameof(RazorProjectEngine.Create))]
        public static RazorEngine CreateDesignTime()
        {

(19) src\Razor\src\Microsoft.AspNetCore.Razor.Language\RazorEngine.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version. The recommended alternative is " + nameof(RazorProjectEngine) + "." + nameof(RazorProjectEngine.Create))]
        public static RazorEngine CreateDesignTime(Action<IRazorEngineBuilder> configure) => CreateCore(RazorConfiguration.Default, true, configure);

(20) src\Razor\src\Microsoft.AspNetCore.Razor.Language\RazorEngine.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static RazorEngine CreateEmpty(Action<IRazorEngineBuilder> configure)
        {

(21) src\Razor\src\Microsoft.AspNetCore.Razor.Language\RazorEngine.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static RazorEngine CreateDesignTimeEmpty(Action<IRazorEngineBuilder> configure)
        {

(22) src\Razor\src\Microsoft.AspNetCore.Razor.Language\RazorEngineBuilderExtensions.cs

Links: [master] | [release/2.2] File a bug for this

    [Obsolete("This class is obsolete and will be removed in a future version. The recommended alternative is " + nameof(RazorProjectEngineBuilderExtensions) + ".")]
    public static class RazorEngineBuilderExtensions
    {

(23) src\Razor\src\Microsoft.CodeAnalysis.Razor\DefaultTagHelperDescriptorProvider.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete(
            "This property is obsolete will not be honored. Documentation will be included if " +
            "TagHelperDescriptorProviderContext.IncludeDocumentation is set to true. Hidden tag helpers will" +

(24) src\Razor\src\Microsoft.AspNetCore.Razor.Language\CodeGeneration\DocumentWriter.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method was intended to be static, use CreateDefault instead.")]
        public DocumentWriter Create(CodeTarget codeTarget, RazorCodeGenerationOptions options)
        {

(25) src\Razor\src\Microsoft.AspNetCore.Razor.Language\Extensions\FunctionsDirective.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static void Register(IRazorEngineBuilder builder)
        {

(26) src\Razor\src\Microsoft.AspNetCore.Razor.Language\Extensions\InheritsDirective.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static void Register(IRazorEngineBuilder builder)
        {

(27) src\Razor\src\Microsoft.AspNetCore.Razor.Language\Extensions\SectionDirective.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("This method is obsolete and will be removed in a future version.")]
        public static void Register(IRazorEngineBuilder builder)
        {

(28) src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\ProjectSystem\ProjectChangeEventArgs.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("Adding this as a workaround to unblock live share")]
        public ProjectChangeEventArgs(string projectFilePath, ProjectChangeKind kind)
        {

(29) src\Razor\src\Microsoft.CodeAnalysis.Razor.Workspaces\ProjectSystem\ProjectChangeEventArgs.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("Adding this as a workaround to unblock live share")]
        public ProjectChangeEventArgs(string projectFilePath, string documentFilePath, ProjectChangeKind kind)
        {

(30) src\Razor\test\Microsoft.AspNetCore.Razor.Test.Common\Language\RazorEngineBuilderExtensions.cs

Links: [master] | [release/2.2] File a bug for this

    [Obsolete("This class is obsolete and will be removed in a future version.")]
    public static class RazorEngineBuilderExtensions
    {

(31) src\Razor\test\Microsoft.VisualStudio.Editor.Razor.Test.Common\Xunit\ForegroundTestCase.cs

Links: [master] | [release/2.2] File a bug for this

        [Obsolete("Called by the de-serializer", error: true)]
        public ForegroundTestCase()
        {

mkArtakMSFT commented 5 years ago

Looks like everything here is in Razor-related areas. @NTaylorMullen, this is all yours now.

NTaylorMullen commented 5 years ago

https://github.com/aspnet/AspNetCore-Tooling/commit/ba6450a69532875cd1878c4729fa6b8693c95188