search

dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.59k stars 10.06k forks source link

Make FileResult and ContentResult use Pipelines #7840

Open jkotalik opened 5 years ago

jkotalik commented 5 years ago

Both executors are using the response stream today. These can go ahead and use the BodyPipe instead.

https://github.com/aspnet/AspNetCore/blob/c565386a3ed135560bc2e9017aa54a950b4e35dd/src/Mvc/Mvc.Core/src/Infrastructure/ContentResultExecutor.cs#L24 https://github.com/aspnet/AspNetCore/blob/7af971838ec527221f4260bae3bf11e8ae5b035c/src/Mvc/Mvc.Core/src/Infrastructure/FileResultExecutorBase.cs#L361

jkotalik commented 5 years ago

cc @mkArtakMSFT

jkotalik commented 5 years ago

I think we should punt this issue for now to a different milestone. Pipeline support will have some design changes that should be awaited.

rynowak commented 5 years ago

pipelines.GetAwaiter().GetResult()

jkotalik commented 5 years ago

need an AsTask() bro cause it be a ValueTask.

rynowak commented 5 years ago

SRS talk If this is going to change, I think we can afford to wait.

rynowak commented 5 years ago

I expect our usage of pipelines to be pretty straightforward in this area, so we're not going to generate any useful feedback or blocking issues from doing it.

jkotalik commented 5 years ago

@davidfowl to drive this bus.

ghost commented 2 years ago

Thanks for contacting us.

We're moving this issue to the .NET 7 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s). If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

ghost commented 2 years ago

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s). If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.