dotnet / aspnetcore

ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.
https://asp.net
MIT License
35.35k stars 9.99k forks source link

Correct parameters used with default (hosted) pools #8862

Closed dougbu closed 5 years ago

dougbu commented 5 years ago

The AzDO pipeline change @MattGal made in aspnet/Extensions@d4522c6b2e should work short term. But, the future-proof way to do this is to specify just the vmImage and not the pool name when using the default (hosted) pools e.g.

pool:
  vmImage: ubuntu-16.04

instead of

pool:
  name: Hosted Ubuntu 1604
  vmImage: ubuntu-16.04

Background is AzDO is merging their various pools into one and deprecating the name parameter when using these pools (soon to be "this pool").

We need to do this across our repos, including release/2.x branches:

dougbu commented 5 years ago

Where necessary i.e. when we've hit resource limits using the default (hosted) pools in release/2.x branches, move to using BYOC pools (see also aspnet/AspNetCore-Internal#2033).

In addition, use this opportunity to clean up any references to the following deprecated pools.

dougbu commented 5 years ago

We also have AzDO YAML files using the old "phase" schema that AzDO has deprecated. Should move to current "job" schema. See https://github.com/dotnet/arcade/blob/master/Documentation/AzureDevOps/PhaseToJobSchemaChange.md

dougbu commented 5 years ago

Done everywhere