dotnet / buildtools

Build tools that are necessary for building the .NET Core projects
477 stars 240 forks source link

Opt out of importing Directory.Build.props/targets in generated project.csproj #2198

Closed wtgodbe closed 6 years ago

wtgodbe commented 6 years ago

Since the generated project.csproj is an SDK style project, it was automatically importing the root Directory.Build.props/targets in SDK-style repos that consumed it. This was causing problems - for example, in CoreFx & Standard, project.csproj would get PackageReferences that were defined in Arcade, but didn't have access to the right RestoreSource, causing restore errors if those packages weren't already in the cache. This PR turns off the automatic Directory.Build.props/targets imports.

@weshaggard @ericstj PTAL