search

dotnet / buildtools

Build tools that are necessary for building the .NET Core projects
477 stars 240 forks source link

Fix GitHubVersionsRepoUpdater retries for "Update is not a fast forward" #2221

Closed dagood closed 3 years ago

dagood commented 5 years ago

GitHubVersionsRepoUpdater.UpdateBuildInfoAsync should retry when it hits "Update is not a fast forward". That exception simply means some other repo updated dotnet/versions between the beginning of the current update and submission. But it looks like there’s a bug where GitHubVersionsRepoUpdater.cs#L149 doesn't catch NotFastForwardUpdateException.

This is ironic aftermath of the ProdCon v1 work: I added this exception type so I could add tests that make sure ProdCon v1's build manifest publish will do retries.

ViktorHofer commented 3 years ago

// Auto-generated message

Going forward, the .NET team is using https://github.com/dotnet/arcade to develop the code and issues formerly in this repository. Feel free to reopen/move this issue if it still applies to servicing branches in this repository, or source code which now resides in the Arcade repository.