Rip out the static ParseResult and instead compute a PR once and flow it through the command handlers

dotnet / cli-lab

A guided tool will be provided to enable the controlled clean up of a system such that only the desired versions of the Runtime and SDKs remain.

MIT License

602 stars 55 forks source link

Rip out the static ParseResult and instead compute a PR once and flow it through the command handlers #290

Closed baronfel closed 3 months ago

baronfel commented 4 months ago

Fixes #287

This removes the use of Environment.GetCommandLineArgs() in the static constructor of the CommandLineConfigs type. Since this was being used in other commands directly, we now have to inject a ParseResult into the various commands. This also means that the current implementation of the --version option didn't work anymore, so I did what is the common/conventionally-done thing which is pulling --version out into a top-level command.

baronfel commented 3 months ago

/azp run

azure-pipelines[bot] commented 3 months ago

Azure Pipelines successfully started running 1 pipeline(s).