dotnet / cli-lab

A guided tool will be provided to enable the controlled clean up of a system such that only the desired versions of the Runtime and SDKs remain.
MIT License
625 stars 56 forks source link

[NETSDKE2E][MAC]The text "Used by VS for Mac..." next to net 9 SDK needs to be updated as VS Mac has been end of life. #311

Open vdanche opened 1 month ago

vdanche commented 1 month ago

To Reproduce 1.Prepare a clean Intel 2.install dotnet-core-uninstall(1.7.550802)

  1. Use the following commands to install the tool:
    mkdir -p ~/dotnet-core-uninstall
    tar -zxvf dotnet-core-uninstall.tar.gz -C ~/dotnet-core-uninstall
    cd ~/dotnet-core-uninstall
    ./dotnet-core-uninstall list

    4.Install 9.0.rc2 sdk and some others sdk . e.g 8.0.403 sdk...

  2. Run "./dotnet-core-uninstall list" 6.check the output of dotnet-core-uninstall list

Expected Result: The output of dotnet-core-uninstall list display well.

Actual Result: The text "Used by VS for Mac..." next to net 9 SDK needs to be updated as VS Mac has been end of life. Image

dotnet --info: Image

marcpopMSFT commented 1 month ago

I kind of think we should just remove this check entirely. @baronfel @joeloff https://github.com/dotnet/cli-lab/blob/25e91f1d39ad446131c0fe4bc998c5a33e766773/src/dotnet-core-uninstall/Shared/VSVersioning/VisualStudioSafeVersionsExtractor.cs#L53

not a blocker.