dotnet / codeformatter

Tool that uses Roslyn to automatically rewrite the source to follow our coding styles
MIT License
1.24k stars 244 forks source link

Revert "The rule that makes types explicit should add a using when it needs to qualify type." #211

Closed srivatsn closed 8 years ago

srivatsn commented 8 years ago

Reverts dotnet/codeformatter#210

It turns out that ImportAdder API in Roslyn has a bug where it doesn't check if adding the using causes any ambiguity errors. This causes this rule to break code. So reverting this change until the Roslyn bug can be addressed.

srivatsn commented 8 years ago

FYI @lgolding @genlu

If you are curious, the issue is https://github.com/dotnet/roslyn/issues/8604

ghost commented 8 years ago

Fascinating :-)

genlu commented 8 years ago

Wow, this is hard :)