First commit fixes a bug I discovered in the command line options that were added. This was broken but will now work:
codeformatter.exe analyze <targetProjFile> --use-analyzers --analyzers <pathToAnalyzerDLL>
and this continues to work:
codeformatter.exe analyze <targetProjFile> --use-analyzers --analyzers <pathToTxtFileWithAnalyzerDLLs>
Tests have been rewritten to correctly test the non-MEF based analyzer loading that was checked in. However only 1 of 5 passes for reasons I'm having trouble debugging (tests for assemblies besides the 1.2.0-beta1 version claim to have no analyzers in it). The scenarios they are meant to test work correctly on the command line though (manually running against those test analyzer assemblies produces analyzer diagnostics).
Log analyzer execution time to the console if desired. The Roslyn ErrorLogger doesn't make it easy to insert that information in SARIF format at the moment. We can add it later as necessary.
Tagging @basoundr and @srivatsn. You'll definitely want the fix in the first bullet for playing with this tomorrow.
srivatsn
commented
8 years ago
For https://github.com/dotnet/codeformatter/issues/225
codeformatter.exe analyze <targetProjFile> --use-analyzers --analyzers <pathToAnalyzerDLL>and this continues to work:codeformatter.exe analyze <targetProjFile> --use-analyzers --analyzers <pathToTxtFileWithAnalyzerDLLs>Tagging @basoundr and @srivatsn. You'll definitely want the fix in the first bullet for playing with this tomorrow.