search

dotnet / codeformatter

Tool that uses Roslyn to automatically rewrite the source to follow our coding styles
MIT License
1.24k stars 244 forks source link

Convert codeformatter to SDK projects and update to latest dependencies #275

Closed ericstj closed 6 years ago

ericstj commented 6 years ago

I was trying to use codeformatter on the latest corefx projects when porting some source over and encountered a few issues.

  1. It couldn't handle SDK projects
  2. It couldn't handle C# 7 syntax

Those were both due to using old versions of MSBuild and Roslyn respectively. I fixed those and in the process updated the repo to use SDK projects, fixed the tests to pass, and centralized the dependency information to the root of the repository.

This fixes a number of issues. I tried to go through the issue list and mark the ones that seemed fixed and added some regression tests to prove it.

Fixes #272 Fixes #271 Fixes #268 Fixes #262 Fixes #261 Fixes #258 Fixes #256 Fixes #255 Fixes #241

terrajobst commented 6 years ago

What a monster PR! Thanks for doing this @ericstj.