search

dotnet / codeformatter

Tool that uses Roslyn to automatically rewrite the source to follow our coding styles
MIT License
1.24k stars 244 forks source link

v1.0.0-alpha release doesn't contain System.Collections.Immutable #45

Closed davkean closed 9 years ago

davkean commented 9 years ago

The release I downloaded from https://github.com/dotnet/codeformatter/releases/tag/v1.0.0-alpha, doesn't contain System.Collections.Immutable and hence crashes.

jaredpar commented 9 years ago

Need to update the release anyways. I will add this collection in.

davkean commented 9 years ago

It looks like you are relying on it being in the GAC, but VS owns that version and it might not match the version that you use.

jaredpar commented 9 years ago

@davkean no one owns the GAC. Everyone is equally free to destroy it ;)

jaredpar commented 9 years ago

@davkean turns out we are not relying on it to be in the GAC. Build expected it to be copy local like all of our other references. It just turns out that something else installed it into the GAC so naturally MSBuild decided to stop putting it in the output. Because what's installed in the GAC should definitely be changing what my build outputs are.

davkean commented 9 years ago

Side note, we've got a bug around this against the MSBuild team.

jaredpar commented 9 years ago

@davkean

Is it something they indicated they will fix? The behavior is actually really infectious and ends up affecting how Visual Studio projects generate reference entries in files.