dotnet / command-line-api

Command line parsing, invocation, and rendering of terminal output.
https://github.com/dotnet/command-line-api/wiki
MIT License
3.34k stars 375 forks source link

List<CliToken> tokenList should be renamed to List<CliToken> tokens #2440

Open PonchoPowers opened 3 weeks ago

PonchoPowers commented 3 weeks ago

There are a few mentions of tokenList left in Tokenizer.Tokenize and they should be renamed to remove the type "List" so that the naming conforms to the conventions of the .NET Framework.

Also, where (CliSymbol Symbol, CliTokenType TokenType)> tokens is used, the word tokens should be changed to validTokens to avoid any confusion between the list of valid tokens and the list of tokens being built up.