search

dotnet / command-line-api

Command line parsing, invocation, and rendering of terminal output.
https://github.com/dotnet/command-line-api/wiki
MIT License
3.34k stars 375 forks source link

Update ApprovalTests dependency #2446

Closed adamsitnik closed 1 week ago

adamsitnik commented 1 week ago

Required to fix the warnings we get from security tooling regarding https://msrc.microsoft.com/update-guide/vulnerability/CVE-2024-0056

Please keep in mind that the change affects only the tests projects, the product was never affected.

adamsitnik commented 1 week ago

IMO tests should either target the version that the libraries they test target (net462) or the latest version (net481). I think latest makes sense here. Arcade defines a property for that: NetFrameworkCurrent.

I've updated the projects to use NetFrameworkCurrent. One thing that I don't like about it is that it's pure magic for contributors who are not familiar with Arcade. But assuming the contributors have 4.8.1 SDK installed, it should not be a problem.

ViktorHofer commented 1 week ago

Yeah I get your point. I think NetFrameworkCurrent is mostly self-descriptive. It means the current version of .NET Framework which 4.8.1.

adamsitnik commented 1 week ago

@jonsequitur since this PR does not affect the product itself I'll go ahead and merge it. Please let me know if something needs to be changed.