We encountered and issue with CliDiagnostic not being able to get to the CommandValueResult. I added it to the ParseResult which needed it, and updated the Powderhouse tests in ParserTests
There may be additional work needed to for CliDiagnostic to include the CommandValueResult.
We discussed supplying a common base class for ValueResults and CommandValueResults, but I did not include this.
While CommandResult looks separable, it can't be sent onward outside core as long as it derives from SymbolResult which retains the link to the SymbolTree which needs to remain behind.
We encountered and issue with
CliDiagnosticnot being able to get to theCommandValueResult. I added it to theParseResultwhich needed it, and updated the Powderhouse tests inParserTestsThere may be additional work needed to for
CliDiagnosticto include theCommandValueResult.We discussed supplying a common base class for
ValueResultsandCommandValueResults, but I did not include this.While
CommandResultlooks separable, it can't be sent onward outside core as long as it derives fromSymbolResultwhich retains the link to theSymbolTreewhich needs to remain behind.