search

dotnet / command-line-api

Command line parsing, invocation, and rendering of terminal output.
https://github.com/dotnet/command-line-api/wiki
MIT License
3.36k stars 376 forks source link

add benchmarks #469

Closed jonsequitur closed 5 years ago

jonsequitur commented 5 years ago

A small benchmark suite would be helpful so that we can measure work on performance improvements.

Kosat commented 5 years ago

Hello @jonsequitur ,

If I understand correctly, you would like to add a few BenchmarkDotNet benchmarks into a new project , let it be src/System.CommandLine.Benchmarks. So that contributors would locally check their changes for performance degradation as explained here.

Kindly, can I take this task?

jonsequitur commented 5 years ago

That approach sounds good. We'd absolutely appreciate the help.

Thanks @Kosat!

billwert commented 5 years ago

hey @jonsequitur - I think we should host these in the dotnet/performance repo as we do the ml.net. What do you think? That way we can run them often for you and you'll have trends (currently internal only, we're working on a reporting story for external.)

billwert commented 5 years ago

hi @Kosat! @jonsequitur and I chatteda about this yesterday. For now we think it is best to put the benchmarks in a place in this repo to enable highly iteratitve workflows for contributors here. Once we've reached some point of stability we'll look at putting this in the perf repo and lab to guard against regression.

If you're not familiar with it you might be able to use the nuget support built into BDN. Wanted to call it out if you hadn't seen it.