dotnet / core

.NET news, announcements, release notes, and more!
https://dot.net
MIT License
20.99k stars 4.91k forks source link

.NET Core 2.2.0 #2098

Closed vivmishra closed 5 years ago

vivmishra commented 5 years ago

.NET Core 2.2.0

Release Notes Download 2.2.0

Please report any issues you find with 2.2.0, either responding to this issue, creating a new issue or creating a new issue in one of the following repos:

TheRealEdwardCullen commented 5 years ago

Docker image uses file: "https://dotnetcli.blob.core.windows.net/dotnet/Sdk/2.2.100/dotnet-sdk-2.2.100-win-x64.zip" which is "2.2.100-rtm-009602"

Official release is "2.2.100-rtm-009607".

Normally, these files are synchronised, so I can get the hash from the release announcement.

Raised with dotnet-docker as #855

TheRealEdwardCullen commented 5 years ago

2105

AlexSapple commented 5 years ago

Hi, after updating my Rest API project to .net core2.2, all the get requests failed with 415 status. After a long headache, it seems that anything that doesn't include a content type header fails - however, surely a GET in REST wouldn't ever include a content type (as there is no request body at all??). Is this behaviour expected? (something in WEBAPI changed?? or something to to with the work around HTTP2??) The identical calls worked without issue on 2.1.6. (This is over HTTP).

thanks.

KamranShahid commented 5 years ago

For Visual studio 2017 .net core 2.2 option should come rather then a need of VS 2019. I have done easy migration of my .net core 2.0 till .net core 2.1.6 as i update my ide then the nuget packages (and project level if ever needed). Now though i wanted to use .net core 2.2 in my three applications (two console application which are also act as windows service on windows platform and one web api project ) but i can't

vivmishra commented 5 years ago

CC @muratg ; @Eilon for question from @AlexSapple

vivmishra commented 5 years ago

@KamranShahid : Sorry for the inconvenience, you can install .NET Core 2.2 using the installer package from the download page and use it with VS 2017. .NET Core 2.2 will show in the project options as a target when you install the 2.2 SDK.

muratg commented 5 years ago

@mkArtakMSFT @rynowak @pranavkm

Could you take a look at @AlexSapple's question above? Related to ProblemDetails feature?

rynowak commented 5 years ago

@AlexSapple - this is the explanation for what changed https://github.com/aspnet/AspNetCore/issues/4396

KamranShahid commented 5 years ago

@KamranShahid : Sorry for the inconvenience, you can install .NET Core 2.2 using the installer package from the download page and use it with VS 2017. .NET Core 2.2 will show in the project options as a target when you install the 2.2 SDK.

My point is Visual Studio 2017 should have option to update as when we have releases of 2.1.0 til 2.1.6 rather then doing separate sdk download

@vivmishra which particular file i should dowonload, SDK or run time? I think SDK installer for windows 64 version

fugaku commented 5 years ago

I can no longer find HttpContentFormDataExtensions in System.Net.Http

Is it moved somewhere?

tomap commented 5 years ago

Hi, we have a "fairly" vanilla ASP.NET Core app, in Docker Linux (microsoft/dotnet:2.2-aspnetcore-runtime) When we switched from 2.1 to 2.2, we saw a +40Mb increase (from 80Mb to 120Mb) (same scenario: load the docker, do the 2 same calls to "health" endpoints & swagger endpoints)

We suspect this has something to do with the Garbage collector. In .Net Core 2.1, we had to add the following to constraint memory use: <ServerGarbageCollection>false</ServerGarbageCollection> Maybe the behavior of this has change

Would you have leads on where to look ? how to confirm the hunch :)

Thank you

muratg commented 5 years ago

@MeiChin-Tsai Was there any change in 2.2 to cause any memory usage increase in @tomap's scenario above?

karelz commented 5 years ago

@fugaku why do you think it is gone? See https://apisof.net/catalog/System.Net.Http.HttpContentFormDataExtensions - it should be in System.Net.Http.Formatting.dll, is that not the case?

dcb99 commented 5 years ago

Hi, after updating my Rest API project to .net core2.2, all the get requests failed with 415 status. After a long headache, it seems that anything that doesn't include a content type header fails - however, surely a GET in REST wouldn't ever include a content type (as there is no request body at all??). Is this behaviour expected? (something in WEBAPI changed?? or something to to with the work around HTTP2??) The identical calls worked without issue on 2.1.6. (This is over HTTP).

thanks.

I had a similar issue, and it was resolved after making sure the program key in launch.json configurations referenced netcoreapp2.2 and not netcoreapp2.1

rachelleahr commented 5 years ago

Hi, I have an app deployed on Azure and after updating to version 2.2 it is no longer working. Any idea when Azure will support netcoreapp2.2 ?

karelz commented 5 years ago

@racheldelman what do you mean by Azure in this context? What do you mean by "no longer working"? First try to find out if it is problem of Azure service not supporting 2.2 (I would recommend to watch official communication channels for that particular service in such case) or if your app simply is broken by the upgrade (something you would need to investigate & isolate).

rachelleahr commented 5 years ago

@karelz my application works perfectly fine locally so I assume it is an azure specific issue. Thanks!

muratg commented 5 years ago

@racheldelman Try West Central US region. I know 2.2 is there.

Though your issue could well be unrelated as well. So more info needed.

DickBaker commented 5 years ago

wrong URL at conclusion of SDK 2.2.101 install: https://aka.ms/20-p2-rel-notes (points to 2.0.0 release notes)

2018-12-27_dotnet22101

DickBaker commented 5 years ago

the instruction to use dotnet to show correct installation of SDK 2.2.101 doesn't work if you had previously installed the SxS preview of 3.0.x as that shows thru instead (presumably PATH trumpted) 2018-12-27 dn3pre 2018-12-27 dn2ok

livarcocc commented 5 years ago

@DickBaker not really. The SDKs are side-by-side and installed next to each other. However, by default, we use the latest one available. So, if you have 2.2.101 and 3.0.100-preview, 3.0 being greater will be picked up. However, with the 3.0 SDK you should be able to target all the previous TFMs as well.

So, you can build a netcoreapp2.2 app using the 3.0 SDK.

karelz commented 5 years ago

@DickBaker thanks for reporting the bad URL - it seems to come from here: https://github.com/dotnet/core-setup/blob/b3b533c92fa1911767d382d174b6f2e6356cfae1/src/pkg/packaging/windows/sharedframework/bundle.wxl#L66

@rakeshsinghranchi do you own it in core-setup repo? cc @vivmishra @leecow

DickBaker commented 5 years ago

@livarcocc thanks for stating that the 3.0.100-preview would be used if present (I didn't know that). However I now have these points 1 how would I force using all 2.2.101 exclusively (ignoring the 3.0.100-preview) ? 2 surely the purpose of SxS is to isolate different SDK releases. Your way cross-contaminates? 3 your behaviour should be explicitly stated as warning/relnote instead of expected dotnet 2.2.101

BTW although I raised the 2 feedbacks independently, they have been lumped together as single #2098 issue. Surprised as could lead to part(s) being ignored - imho best to separate for SRP.

DickBaker commented 5 years ago

@livarcocc update to BTW in my last posting .. I probably should have read&followed that welcome instruction to post to specific repos, i.e. dotnet/core-setup - for installer issues rather than this catch-all (#2098) issue please move my postings to more focussed drops if appropriate [my bad]

livarcocc commented 5 years ago

@DickBaker we believe that is quite the opposite. Wanting to stay on a particular version if the exception, which is why we roll forward by default and we don't warn. We have no intention of doing so.

As for pinning to a particular version, you can find more information about it here: https://docs.microsoft.com/en-us/dotnet/core/tools/global-json. However, do notice that pinning your SDK version as nothing to do with the .net core version that your application runs against. That is solely determined by the target framework of your application.

braidenstiller commented 5 years ago

When will .Net Core 2.2 be added in the runtime stack for App Service's running Linux? It's currently not an option and since upgrading my project to 2.2, it won't deploy to Azure.

I.e: https://imgur.com/a/S50TMBa

karelz commented 5 years ago

@braidenstiller please monitor App Service announcements, like this one: https://github.com/Azure/app-service-announcements/issues/151

leecow commented 5 years ago

Closing this release discussion issue in favor of https://github.com/dotnet/core/issues/2304.