search

dotnet / corefx-tools

Place to include various misc tools for .NET and .NET Core.
MIT License
58 stars 41 forks source link

perfcollect: crossgen Trusted_Platform_Assemblies key no longer works #104

Open ezsilmar opened 5 years ago

ezsilmar commented 5 years ago

Hello,

There was a PR in coreclr which changed the public API of crossgen tool (https://github.com/dotnet/coreclr/pull/23462). Instead of /Trusted_Platform_Assemblies path[:path...] it now uses /r path [/r path...]. We need to update how perfcollect uses crossgen to respect the new key.

WIP is here: https://github.com/criteo-forks/corefx-tools/tree/crossgen_fix . For now I did a simple conversion. However I thought that maybe we should check crossgen version in perfcollect to support both old and new formats.

What do you think? Thanks!