search

dotnet / corefx-tools

Place to include various misc tools for .NET and .NET Core.
MIT License
58 stars 41 forks source link

Correctly detect Debian in perfcollect #72

Open mleenhardt opened 6 years ago

mleenhardt commented 6 years ago

uname -a doesn't contain "Debian" on Jessie or Stretch.

Output from a microsoft/dotnet:2.0.6-sdk-2.1.104 container using stretch as its base image: uname -a -> "Linux 1a46aee325a3 4.9.87-linuxkit-aufs #1 SMP Wed Mar 14 15:12:16 UTC 2018 x86_64 GNU/Linux" cat /etc/debian_version -> "8.10" cat /etc/issues -> "Debian GNU/Linux 8 \n \l"

Output from a microsoft/dotnet:2.0.6-sdk-2.1.104-jessie container using jessie as its base image: uname -a -> "Linux ae834cf8bd36 4.9.87-linuxkit-aufs #1 SMP Wed Mar 14 15:12:16 UTC 2018 x86_64 GNU/Linux" cat /etc/debian_version -> "9.4" cat /etc/issues -> "Debian GNU/Linux 9 \n \l"

Running ./perfcollect install in the above two containers with the current version that's checking for uname -a results in "ERROR: Auto install unsupported for this distribution. Install perf manually to continue."

janvorli commented 6 years ago

I am not sure why don't we use the standard distro detection way that we use in all of our build and tool initialization scripts in coreclr, corefx and core-setup. The /etc/os-release is the best source of truth for these purposes.